Open Bug 1290158 Opened 5 years ago Updated 3 years ago
Don't generate synthetic paint events for invisible documents
There's some code in the pres shell to generate paint events for invisible documents. In particular, I accidentally triggered it by putting a browser element inside an arrow panel. It then becomes possible for the paint event to be generated before the window has been shown. This confuses any code that assumes that only visible elements can be painted.
Well, why is that code there? Why is it safe to remove?
Comment on attachment 8775625 [details] [diff] [review] Proposed patch Unsetting review request pending an answer to my question, ideally in the form of a commit message.
(In reply to Boris Zbarsky from comment #2) > Well, why is that code there? It's there because Matt added it. He told me that he can't remember why but it was probably due to a test failure. > Why is it safe to remove? Because the tests don't seem to need it.
OK, then presumably Matt or whoever reviewed the addition should review this change, not me...
Attachment #8775625 - Flags: review?(matt.woodrow)
Attachment #8775625 - Flags: review?(matt.woodrow) → review+
Assigning to neil. I suppose the patch should be checked in?
Assignee: nobody → neil
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/472858f465b0 Don't generate synthetic paint events for invisible documents r=mattwoodrow
backed out for perf regression: https://hg.mozilla.org/integration/mozilla-inbound/rev/589d63647e0b
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Joel Maher from comment #9) > backed out for perf regression: > https://hg.mozilla.org/integration/mozilla-inbound/rev/589d63647e0b How can a patch consisting of 100% code removal cause a perf regression?
I am not sure why, possibly the tps test depended on something unintentional here. It is clear that when it was backed out the regression was fixed, for example: https://treeherder.mozilla.org/perf.html#/graphs?timerange=5184000&series=%5Bautoland,1ee437da5d40ec5c28d523e50090d48048b43917,1,1%5D&series=%5Bfx-team,1ee437da5d40ec5c28d523e50090d48048b43917,1,1%5D&series=%5Bmozilla-inbound,1ee437da5d40ec5c28d523e50090d48048b43917,1,1%5D
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.