1290233 - replace uses of nsIXULChromeRegistry

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Tom Tromey :tromey]

The inspector uses nsIXULChromeRegistry in a couple of spots, to see
whether the locale is RTL.
These uses have to be replaced for de-chrome-ification.

Comment 1

[Tom Tromey :tromey]

The use in computed.js doesn't seem needed at all.

The one in layout.js might or might not be; but it doesn't seem to affect the test results
if I remove it.

Comment 2

[Tom Tromey :tromey]

Experiments with the Force RTL add-on show that this code isn't needed.

Comment 3

[Tom Tromey :tromey]

Attachment: Bug 1290233 - remove uses of nsIXULChromeRegistry from inspector;

Review commit: https://reviewboard.mozilla.org/r/72308/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72308/

Comment 4

[Greg Tatum [:gregtatum]]

Comment on attachment 8782018 [details]
Bug 1290233 - remove uses of nsIXULChromeRegistry from inspector;

https://reviewboard.mozilla.org/r/72308/#review69978

Sweet, one more require("chrome") gone.

Comment 5

[Tom Tromey :tromey]

A bit too eager on the chrome removals somehow, one of those was still needed,
until the clipboard changes land.

Comment 6

[Tom Tromey :tromey]

Comment on attachment 8782018 [details]
Bug 1290233 - remove uses of nsIXULChromeRegistry from inspector;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/72308/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9276295f33de
remove uses of nsIXULChromeRegistry from inspector; r=gregtatum

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9276295f33de