Closed Bug 1290305 Opened 3 years ago Closed 3 years ago

Intermittent mozbuild.configure.options.InvalidOptionError: Unknown option: --with-android-version

Categories

(Firefox Build System :: Lint and Formatting, defect)

3 Branch
defect
Not set

Tracking

(firefox50 fixed, firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: chmanchester)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

This is definitely not intermittent.
This is failing because --with-android-version is now in android-ndk.configure, which is included from toolchain.configure, which is not included when building with --disable-compile-environment, which those builds are using.

AFAICT, the android version is not used in such builds, so the fix would be to remove the --with-android-version flag.
gbrown: do you know which change caused this, can we disable/fix this ?
Flags: needinfo?(gbrown)
the dependent bug did.
Flags: needinfo?(gbrown)
(In reply to Mike Hommey [:glandium] from comment #5)
> the dependent bug did.

glandium/chris, can you fix this ?
Flags: needinfo?(mh+mozilla)
Flags: needinfo?(cmanchester)
Assignee: nobody → cmanchester
Flags: needinfo?(mh+mozilla)
Flags: needinfo?(cmanchester)
I have a fix, but I can't really test it on try because the mozconfigs aren't specified as relevant files in the Taskcluster definition.
The value passed is already the default. A recent change makes this argument unrecognized
for --disable-compile-environment builds, so this argument may cause an error.

Review commit: https://reviewboard.mozilla.org/r/68352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68352/
Attachment #8776643 - Flags: review?(mh+mozilla)
Attachment #8776643 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8776643 [details]
Bug 1290305 - Do not pass --with-android-version in mobile/android/config/mozconfigs/common.

https://reviewboard.mozilla.org/r/68352/#review65590
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/786e642852ad
Do not pass --with-android-version in mobile/android/config/mozconfigs/common. r=glandium
This is looking green since it landed.
https://hg.mozilla.org/mozilla-central/rev/786e642852ad
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Comment on attachment 8776643 [details]
Bug 1290305 - Do not pass --with-android-version in mobile/android/config/mozconfigs/common.

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:

can we uplift this to aurora to fix the intermittent failure ?
Attachment #8776643 - Flags: approval-mozilla-aurora?
Comment on attachment 8776643 [details]
Bug 1290305 - Do not pass --with-android-version in mobile/android/config/mozconfigs/common.

Let's take it to fix an intermittent
Attachment #8776643 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.