Closed
Bug 1290322
Opened 6 years ago
Closed 6 years ago
BaselineScript::New parameter order is out of sync
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: mismith, Assigned: mismith, Mentored)
Details
Attachments
(1 file)
|
3.81 KB,
patch
|
efaust
:
review+
|
Details | Diff | Splinter Review |
Check https://dxr.mozilla.org/mozilla-central/source/js/src/jit/BaselineJIT.h#254-262 and https://dxr.mozilla.org/mozilla-central/source/js/src/jit/BaselineJIT.cpp#401-407 |postDebugPrologueOffset| is in the wrong place.
|
Assignee | |
Updated•6 years ago
|
Summary: BaselineScript constructor parameter order is out of sync → BaselineScript::New parameter order is out of sync
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → mismith
Severity: normal → minor
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8775822 -
Flags: review?(efaustbmo)
|
|
Assignee | |
Comment 2•6 years ago
|
||
Fortunately the parameters at the definition site are in the same order as the arguments at the only call site (https://dxr.mozilla.org/mozilla-central/source/js/src/jit/BaselineCompiler.cpp#200-211), so everything works correctly at runtime.
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8775822 [details] [diff] [review] Bug 1290322: Sync up BaselineScript::New parameter order Review of attachment 8775822 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8775822 -
Flags: review?(efaustbmo) → review+
|
|
||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c53938d005cc Sync up BaselineScript::New parameter order. r=efaust
Keywords: checkin-needed
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c53938d005cc
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•