Closed Bug 1290322 Opened 6 years ago Closed 6 years ago

BaselineScript::New parameter order is out of sync

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: mismith, Assigned: mismith, Mentored)

Details

Attachments

(1 file)

Summary: BaselineScript constructor parameter order is out of sync → BaselineScript::New parameter order is out of sync
Assignee: nobody → mismith
Severity: normal → minor
Status: NEW → ASSIGNED
Fortunately the parameters at the definition site are in the same order as the arguments at the only call site (https://dxr.mozilla.org/mozilla-central/source/js/src/jit/BaselineCompiler.cpp#200-211), so everything works correctly at runtime.
Comment on attachment 8775822 [details] [diff] [review]
Bug 1290322: Sync up BaselineScript::New parameter order

Review of attachment 8775822 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8775822 - Flags: review?(efaustbmo) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c53938d005cc
Sync up BaselineScript::New parameter order. r=efaust
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c53938d005cc
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.