1290326 - Wrap signatures in Top Crasher lists, rather than truncating them

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Nicholas Nethercote [inactive]]

Attachment: crash.png

In Top Crasher lists, signatures get truncated, as the attached screenshot shows. Signatures can be quite long and often the truncation omits helpful detail.

(For example, I was just pestering lonnen on IRC because I couldn't find some crashes that I expected to see in the Top Crasher list. Turns out I was searching for a substring in the part of the signature that had been truncated.)

In other places the signatures are wrapped instead of truncated, e.g. in super search results. It would nice if this occurred in Top Crasher results as well.

Comment 1

[Peter Bengtsson [:peterbe]]

Instead of wrapping we ought to use css overflow.

Comment 2

[Nicholas Nethercote [inactive]]

> Instead of wrapping we ought to use css overflow.

Which value? It needs to support searching in the overflowing part.

Comment 3

[Peter Bengtsson [:peterbe]]

Attachment: Screen Shot 2016-08-03 at 10.21.22 AM.png

So that was interesting. Here I have a prototype where the `td.signature-column` has a `overflow:hidden` etc. 
One of the top signatures contains the string "PNecko" but it's not visible. 
When I start typing it finds it but it's not highlighted so I don't know where it is. In fact, it's kinda useless to find out that the text exists (but hidden). 

Tried in Chrome. It's no better there.

Comment 4

[Peter Bengtsson [:peterbe]]

Attachment: Screen Shot 2016-08-03 at 10.26.14 AM.png

This is what happens when you don't truncate the signatures at all. See how the table can't be compressed any more and you get horizontal scrolling. 

This is full-screen here on my 15" macbook. 

The bestest solution is probably to NOT truncate AND to remove some columns. Like Correlations. 

We could also consider putting multiple pieces of data in a shared column. E.g. Combine "Rank", "%" and "Diff" into "Rank/%/Diff" but then you can't sort by Diff. :(

Or combine Signature and Bugzilla IDS like this "<th>Signature<br>Bugzilla IDs</th>".

What do you think?

Comment 5

[Peter Bengtsson [:peterbe]]

Adrian probably has better ideas and opinions here.

Comment 6

[Nicholas Nethercote [inactive]]

Attachment: Super Search wrapping

Super Search results wrap the signature nicely, as this screenshot shows. Can you replicate that?

Comment 7

[[DEACTIVATED] Adrian Gaudebert]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3418

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/902ec79a38245fa4da066208a1ebf74f9661f76a
Fixes bug 1290326 - Do not truncate signatures in Topcrashers. (#3418)

Comment 9

[Peter Bengtsson [:peterbe]]

Yay! This went to prod seconds ago. Oh why didn't we do this earlier?! :)

Comment 10

[Nicholas Nethercote [inactive]]

\o/