Closed
Bug 1290330
Opened 8 years ago
Closed 8 years ago
Properly handle "pan-x pan-y" touch-action value in APZ code
Categories
(Core :: Panning and Zooming, defect, P3)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: gfx-noted)
Attachments
(1 file)
This bug was uncovered while I was working on bug 1288799 to automate the W3C touch-action tests. The case where an element is "touch-action: pan-x pan-y" means that area will get added to both the horizontal pan and vertical pan event region, but the APZ hit-test code doesn't check for this properly. Instead it just treats it as pan-x.
|
Assignee | |
Comment 1•8 years ago
|
||
There's a try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=683069fe5e9c which includes this patch. The patches in bug 1288799 will add automated tests to cover this behaviour.
|
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/67884/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/67884/
Attachment #8775834 -
Flags: review?(botond)
|
|
Assignee | |
Updated•8 years ago
|
Priority: -- → P3
|
|
Assignee | |
Updated•8 years ago
|
Whiteboard: gfx-noted
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8775834 [details] Bug 1290330 - Properly handle pan-x pan-y regions in the APZ hit test. https://reviewboard.mozilla.org/r/67884/#review65118
Attachment #8775834 -
Flags: review?(botond) → review+
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6b695df8579d Properly handle pan-x pan-y regions in the APZ hit test. r=botond
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6b695df8579d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•