Closed Bug 1290375 Opened 3 years ago Closed 3 years ago

In case of crashes for a Marionette test the current test file name has to be logged instead of runner.py

Categories

(Testing :: Marionette, defect)

Version 3
defect
Not set

Tracking

(firefox49 fixed, firefox50 fixed, firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox49 --- fixed
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Keywords: pi-marionette-server)

Attachments

(1 file)

A good example you can see here:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=6e95ea056bf5805c39e141de567f16068b214307&selectedJob=32861414&filter-searchStr=e10s%20fxfn

> PROCESS-CRASH | runner.py | application crashed [@ libc-2.15.so + 0xe7993]

Given that lots of test harnesses have such a file we see dozen of possible bug suggestions on Treeherder. Since yesterday we even collapse all and only show a warning. As result you do not even see bug suggestions anymore.

We should make sure that we log the test file name where the crash happened.
I would like to wait for bug 1202392 which might already improve the situation.
Depends on: 1202392
So the problem here is that the marionette-server side seems to fail to set the test_name correctly:

https://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette_driver/marionette.py#1142

Because of that we are passing None into the mozcrash checker, which then simply uses runner.py.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
So the if condition is not necessary at all here. In case of failures `_send_message()` would raise an exception. When removing it I get correct test file names in the crash report line:

> PROCESS-CRASH | test_addons.py TestSomething.test_crash | application crashed [@ Crash]
Attachment #8778243 - Flags: review?(ato) → review+
Comment on attachment 8778243 [details]
Bug 1290375 - Marionette has to report the test name and not runner.py for crashes.

https://reviewboard.mozilla.org/r/69556/#review66704
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/009c0f237a44
Marionette has to report the test name and not runner.py for crashes. r=ato
https://hg.mozilla.org/mozilla-central/rev/009c0f237a44
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
This helps starring busted mariontte test jobs due to crashes. It would be great to get this backported to aurora and beta.
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.