Check RegExp.prototype.{ignoreCase,multiline} getters in RegExpPrototypeOptimizable

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: arai, Assigned: arai)

Tracking

Trunk
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

Derived from bug 1287524, and related to bug 1263340.

Currently RegExp.prototype.{global,sticky,unicode} getters are checked in RegExpPrototypeOptimizable.
We could add other getters as well, and apply some more optimization in bug 1263340.
That will also prevent mis-optimization when getters are modified.
added ignoreCase and multiline to RegExpPrototypeOptimizable.
also updated missed comment for unicode.
Assignee: nobody → arai.unmht
Attachment #8804172 - Flags: review?(till)
Comment on attachment 8804172 [details] [diff] [review]
Check RegExp.prototype.{ignoreCase,multiline} getters in RegExpPrototypeOptimizable.

Review of attachment 8804172 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8804172 - Flags: review?(till) → review+
Thank you :D

clearing tracking flag, as this is performance thing, not wrong behavior etc.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5ccad372c47a56efc419237861ec4f5f07044c9
Bug 1290414 - Check RegExp.prototype.{ignoreCase,multiline} getters in RegExpPrototypeOptimizable. r=till
https://hg.mozilla.org/mozilla-central/rev/a5ccad372c47
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.