Closed
Bug 1290414
Opened 8 years ago
Closed 8 years ago
Check RegExp.prototype.{ignoreCase,multiline} getters in RegExpPrototypeOptimizable
Categories
(Core :: JavaScript: Standard Library, defect)
Core
JavaScript: Standard Library
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
Details
Attachments
(1 file)
Derived from bug 1287524, and related to bug 1263340. Currently RegExp.prototype.{global,sticky,unicode} getters are checked in RegExpPrototypeOptimizable. We could add other getters as well, and apply some more optimization in bug 1263340. That will also prevent mis-optimization when getters are modified.
|
Assignee | |
Comment 1•8 years ago
|
||
added ignoreCase and multiline to RegExpPrototypeOptimizable. also updated missed comment for unicode.
Assignee: nobody → arai.unmht
Attachment #8804172 -
Flags: review?(till)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8804172 [details] [diff] [review] Check RegExp.prototype.{ignoreCase,multiline} getters in RegExpPrototypeOptimizable. Review of attachment 8804172 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8804172 -
Flags: review?(till) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Thank you :D clearing tracking flag, as this is performance thing, not wrong behavior etc.
status-firefox50:
affected → ---
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5ccad372c47a56efc419237861ec4f5f07044c9 Bug 1290414 - Check RegExp.prototype.{ignoreCase,multiline} getters in RegExpPrototypeOptimizable. r=till
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a5ccad372c47
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•