Closed Bug 1290438 Opened 4 years ago Closed 4 years ago

Windows Start menu icons too high positioned

Categories

(Thunderbird :: General, defect)

Unspecified
Windows 10
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 50.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(2 files)

Bug 1284080 introduced new bigger icons for the Windows Start menu. Thea are a bit too high positioned and should move a bit lower.
Attached patch newIcons.patchSplinter Review
Moved the icons a bit lower. Also added to the Aurora icon behind the bird a halo to make it better differ from the background (Like we also have in about image.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8775945 - Flags: review?(mozilla)
Screenshot for easier review.
Comment on attachment 8775945 [details] [diff] [review]
newIcons.patch

Review of attachment 8775945 [details] [diff] [review]:
-----------------------------------------------------------------

I looked at "before" and "after" in GIMP. Yes, the images moved down a bit (and the halo got added).
One comment: The Aurora image could be a bit bigger since it has space above it. Or maybe not, because then the halo would be cut off.
Perhaps you applied the same scaling to the original images and the Aurora image was a little smaller originally. I don't know. Up to you.
Attachment #8775945 - Flags: review?(mozilla) → review+
Discussed on IRC: Earlybird has the same size egg, only the top is missing. Also, all images have the same scale from some originals. So r+ as stated above.
Maybe land this with DONTBUILD since there is really nothing to build and test here.
https://hg.mozilla.org/comm-central/rev/9094b320bbad
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 50.0
(In reply to Jorg K (GMT+2, PTO during summer) from comment #5)
> Maybe land this with DONTBUILD since there is really nothing to build and
> test here.

Oops, saw this comment after check in. But had a second patch to check in.
Problem of DONTBUILD is Nightly doesn't pick up this patch when no following patch without DONTBUILD exists.
Yes, that's a problem. Anyway, good to do a full push a few times a day to find new bustage originating from M-C early (as they merge M-I to M-C a few times a day).

In the future, when we pay for servers, we need to carefully consider the resources we can afford to spend.
You need to log in before you can comment on or make changes to this bug.