Closed Bug 1290477 Opened 3 years ago Closed 3 years ago
Stop sanitize against milestones in elmo for releases
As we're shifting around how the communication between ship-it and elmo works, milestones on elmo go away. As such, we should remove the verification code in https://dxr.mozilla.org/build-central/source/tools/buildbot-helpers/release_sanity.py#160, I think. Sylvestre, do you agree?
I think so but rail should confirm.
Flags: needinfo?(sledru) → needinfo?(rail)
fyi: all release sanity for release promotion world has been moved/migrated under https://dxr.mozilla.org/build-central/source/tools/lib/python/kickoff/sanity.py As such when/if we remove the verification code: * we'll need to remove it from aforementioned location indicated by Pike (non promotion world) * https://dxr.mozilla.org/build-central/source/tools/lib/python/kickoff/sanity.py#367 (release promotion world)
I don't mind removing this check, just wondering what the workflow looks like now? Are we going to use "latest" signoffs? BTW, this check is disabled for RC builds (there is a checkbox in ship-it).
The latest sign-offs get pulled into ship-it from elmo, and then ship-it keeps track of what it wants to be in a particular beta build, and shares that with the rest of the world on https://product-details.mozilla.org/1.0/l10n/. Tools like elmo that want to show differences per locale between betas can load those files via CORS, and do what they need to do. That pull-pull mechanism replaces the milestones on elmo, which required an authorized human to make POST requests on elmo.
I can take care of this once I get the green light from rail.
Assignee: nobody → mtabara
Got the green light from rail on IRC. I'll follow-up with a patch soon to remove this both on 'oldrelease-runner' and 'default' branches.
Comment on attachment 8780098 [details] Bug 1290477 - Stop sanitize against milestones in elmo for releases https://reviewboard.mozilla.org/r/70902/#review68318
Attachment #8780098 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 8780098 [details] Bug 1290477 - Stop sanitize against milestones in elmo for releases http://hg.mozilla.org/build/tools/rev/f6c55a97b705 deployed
Attachment #8780098 - Flags: checked-in+
also need to do this for the old releaserunner
reviewboard doesn't represent this thing properly...
Attachment #8780109 - Flags: review?(bugspam.Callek)
Attachment #8780109 - Flags: review?(bugspam.Callek) → review+
Thanks for taking care of these whilst I was gone.
Assignee: mtabara → rail
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
apparently releaserunner uses release-sanity from default. grafted in https://hg.mozilla.org/build/tools/rev/a81f0e33c5cc
You need to log in before you can comment on or make changes to this bug.