1290523 - Add support for generating generic-worker tasks

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

The task-graph generation machinery currently only supports docker-worker (and, untested, docker-engine) task descriptions.  We need to support generic-worker, too.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

I was going to add caches, as :grenade has in bug 1280474, but from https://github.com/taskcluster/generic-worker/blob/a5af1415fb549add6e5741b50cbf71aa9f5be02e/payload.go it doesn't look like those are supported.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1290523: support generic-worker task descriptions;

Review commit: https://reviewboard.mozilla.org/r/67992/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67992/

Comment 3

[Pete Moore [:pmoore][:pete]]

(In reply to Dustin J. Mitchell [:dustin] from comment #1)
> I was going to add caches, as :grenade has in bug 1280474, but from
> https://github.com/taskcluster/generic-worker/blob/
> a5af1415fb549add6e5741b50cbf71aa9f5be02e/payload.go it doesn't look like
> those are supported.

That's right, currently it is not implemented. Note though, the payload is defined here for windows builds:
https://github.com/taskcluster/generic-worker/blob/f6ff33a55542c9a860259b4844c757fbf2a13179/payload_windows.go

(the link you posted was for non-windows builds of generic worker due to line 1 of that file)

Comment 4

[Pete Moore [:pmoore][:pete]]

Comment on attachment 8776067 [details]
Bug 1290523: support generic-worker task descriptions;

https://reviewboard.mozilla.org/r/67992/#review66038

lgtm

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15664ea8ffb1
support generic-worker task descriptions; r=pmoore

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/15664ea8ffb1