Add support for generating generic-worker tasks

RESOLVED FIXED

Status

Taskcluster
Task Configuration
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dustin, Assigned: dustin)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

The task-graph generation machinery currently only supports docker-worker (and, untested, docker-engine) task descriptions.  We need to support generic-worker, too.
I was going to add caches, as :grenade has in bug 1280474, but from https://github.com/taskcluster/generic-worker/blob/a5af1415fb549add6e5741b50cbf71aa9f5be02e/payload.go it doesn't look like those are supported.
Created attachment 8776067 [details]
Bug 1290523: support generic-worker task descriptions;

Review commit: https://reviewboard.mozilla.org/r/67992/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67992/
Attachment #8776067 - Flags: review?(rthijssen)
Attachment #8776067 - Flags: review?(rthijssen) → review?(pmoore)
(In reply to Dustin J. Mitchell [:dustin] from comment #1)
> I was going to add caches, as :grenade has in bug 1280474, but from
> https://github.com/taskcluster/generic-worker/blob/
> a5af1415fb549add6e5741b50cbf71aa9f5be02e/payload.go it doesn't look like
> those are supported.

That's right, currently it is not implemented. Note though, the payload is defined here for windows builds:
https://github.com/taskcluster/generic-worker/blob/f6ff33a55542c9a860259b4844c757fbf2a13179/payload_windows.go

(the link you posted was for non-windows builds of generic worker due to line 1 of that file)
Comment on attachment 8776067 [details]
Bug 1290523: support generic-worker task descriptions;

https://reviewboard.mozilla.org/r/67992/#review66038

lgtm
Attachment #8776067 - Flags: review?(pmoore) → review+

Comment 5

2 years ago
Pushed by dmitchell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15664ea8ffb1
support generic-worker task descriptions; r=pmoore

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/15664ea8ffb1
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.