Closed
Bug 1290525
Opened 8 years ago
Closed 8 years ago
Cancelling a single buildbot job from revision dropdown doesn't work
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
References
Details
Attachments
(1 file)
Unfortunately this codepath wasn't well tested. :/ We found this when ShrutiJ was working on bug 1289138. It was first introduced in bug 1278800, I'm a bit embarassed that I didn't notice the problem when reviewing the patch there.
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8776062 [details] [review] [treeherder] wlach:1290525 > mozilla:master Hey Ed, can you take a look at this one? It's pretty simple -- perhaps ideally we would do some refactoring to make this mistake harder to make, but I figured it might not be worth it to go that far since we're moving away from buildbot (I also didn't want to block ShrutiJ's work on a more involved solution)
Attachment #8776062 -
Flags: review?(emorley)
Updated•8 years ago
|
Attachment #8776062 -
Flags: review?(emorley) → review+
Comment 3•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/420bd613062432857a460d193a93a4313e3c17ad Bug 1290525 - Fix cancelling buildbot jobs from revision bar (#1752)
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•