Closed Bug 1290549 Opened 9 years ago Closed 9 years ago

Provisioner methods use route parameters without deferAuth, which doesn't work

Categories

(Taskcluster :: Services, defect)

Product:
Taskcluster
Component:
Services
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dustin, Assigned: dustin)

Details

If you have route: '/state/:workerType', scopes: [['aws-provisioner:view-worker-type:<workerType>']], but no deferAuth: true, then the scope required is the literal string 'aws-provisioner:view-worker-type:<workerType>', so things like ''aws-provisioner:view-worker-type:garbage-*' don't work. This is a problem for state(workerType) and for the newly added terminateAllInstancesOfWorkerType(workerType)
Deployed.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Commit pushed to master at https://github.com/taskcluster/taskcluster-lib-api https://github.com/taskcluster/taskcluster-lib-api/commit/014025fba98a479cae0a5f5c4903353a7d7d2215 Use `req.params` by default when deferAuth is false [Bug 1290549](https://bugzilla.mozilla.org/show_bug.cgi?id=1290549) identifies at least one place where this is assumed to be the case, and there are probably more.
Component: AWS-Provisioner → Services
You need to log in before you can comment on or make changes to this bug.