Closed Bug 1290600 Opened 5 years ago Closed 5 years ago

Create the schema for the Proxy API

Categories

(WebExtensions :: Request Handling, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: mattw, Assigned: mattw)

Details

(Whiteboard: [proxy] triaged)

Attachments

(1 file)

The schema is proposed here: https://docs.google.com/document/d/1W45o5X2bFRPrTaQDFp9IzTJ8njCVfEgyENS7i2owaUI/edit?pref=2&pli=1#heading=h.xsd5b4xyito3

It supports registering proxy scripts declaratively, closely following the approach used to register content scripts: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Content_scripts#Loading_content_scripts.

The schema has one event, onProxyError, which will work very similarly to https://developer.chrome.com/extensions/proxy#event-onProxyError.
Comment on attachment 8776167 [details]
Bug 1290600 - Create the schema for the proxy API.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68066/diff/1-2/
Attachment #8776167 - Flags: feedback?(kmaglione+bmo)
Comment on attachment 8776167 [details]
Bug 1290600 - Create the schema for the proxy API.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68066/diff/2-3/
Attachment #8776167 - Flags: feedback?(kmaglione+bmo)
Attachment #8776167 - Flags: feedback?(kmaglione+bmo)
Priority: -- → P1
Whiteboard: [proxy] → [proxy] triaged
I'd like to hold off on this for a few days until I've had a chance to go over the design with Kris and Johann.
Comment on attachment 8776167 [details]
Bug 1290600 - Create the schema for the proxy API.

clearing the review flag until this is ready
Attachment #8776167 - Flags: review?(aswan)
This is basically the same schema that Chrome uses here: https://chromium.googlesource.com/chromium/src/+/f35c32b023487569ba0d9779906b331dd795c829/chrome/common/extensions/api/proxy.json.  The only difference is that we don't have a ChromeSetting equivalent.  We may want to add something like that in the future, but for now I added support for proxy.settings the same way storage.local and storage.sync are implemented in the Storage schema.
Component: WebExtensions → WebExtensions: Request Handling
Attachment #8776167 - Flags: review?(aswan)
The schema will be added in bug 1295807.
No longer blocks: webextensions-proxy-api
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.