Automate tracing of the CycleDetector::Set

ASSIGNED
Assigned to

Status

()

Core
JavaScript: GC
P3
normal
ASSIGNED
2 years ago
4 months ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

({triage-deferred})

Trunk
triage-deferred
Points:
---

Firefox Tracking Flags

(firefox50 affected)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8776172 [details] [diff] [review]
7_fix_cycle_detector_set-v0.diff

This gets rid of some manual tracing.
Attachment #8776172 - Flags: review?(jcoppeard)
Comment on attachment 8776172 [details] [diff] [review]
7_fix_cycle_detector_set-v0.diff

Review of attachment 8776172 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Total nit, but could we add a cycleDetectorSet() method to the context to get rid of the .get()s?
Attachment #8776172 - Flags: review?(jcoppeard) → review+
Keywords: triage-deferred
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.