1290612 - XPCNativeSet::NewInstanceMutate() is always called with a non-null first argument

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Andrew McCreight [:mccr8]]

It has a single call site, which is immediately after a null check of the value passed in as the first argument. (This is fortunate, because the code that would run if the argument was null is wrong.)

Comment 1

[Andrew McCreight [:mccr8]]

This is the one callsite, in XPCNativeSet::GetNewOrUsed():

    if (otherSet)
        set = NewInstanceMutate(otherSet, newInterface, position);

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d84c376c45ad

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1290612 - XPCNativeSet::NewInstanceMutate() is always called with a non-null first argument.

Review commit: https://reviewboard.mozilla.org/r/68180/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68180/

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8776399 [details]
Bug 1290612 - XPCNativeSet::NewInstanceMutate() is always called with a non-null first argument.

https://reviewboard.mozilla.org/r/68180/#review65456

Comment 4

[Andrew McCreight [:mccr8]]

Thanks for the reviews. I'm going to try to rebase and push to MozReview so ignore any review requests you get. I'm not sure how this is supposed to work with MozReview...

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 8776399 [details]
Bug 1290612 - XPCNativeSet::NewInstanceMutate() is always called with a non-null first argument.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68180/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2a6aaf59783
XPCNativeSet::NewInstanceMutate() is always called with a non-null first argument. r=mrbkap

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b2a6aaf59783