XPCNativeSet::NewInstanceMutate() is always called with a non-null first argument

RESOLVED FIXED in Firefox 51

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla51
Points:
---

Firefox Tracking Flags

(firefox50 affected, firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
It has a single call site, which is immediately after a null check of the value passed in as the first argument. (This is fortunate, because the code that would run if the argument was null is wrong.)
(Assignee)

Comment 1

2 years ago
This is the one callsite, in XPCNativeSet::GetNewOrUsed():

    if (otherSet)
        set = NewInstanceMutate(otherSet, newInterface, position);

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d84c376c45ad
(Assignee)

Comment 2

2 years ago
Created attachment 8776399 [details]
Bug 1290612 - XPCNativeSet::NewInstanceMutate() is always called with a non-null first argument.

Review commit: https://reviewboard.mozilla.org/r/68180/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68180/
Attachment #8776399 - Flags: review?(mrbkap)
Attachment #8776399 - Flags: review?(mrbkap) → review+
Comment on attachment 8776399 [details]
Bug 1290612 - XPCNativeSet::NewInstanceMutate() is always called with a non-null first argument.

https://reviewboard.mozilla.org/r/68180/#review65456
(Assignee)

Comment 4

2 years ago
Thanks for the reviews. I'm going to try to rebase and push to MozReview so ignore any review requests you get. I'm not sure how this is supposed to work with MozReview...
(Assignee)

Comment 5

2 years ago
Comment on attachment 8776399 [details]
Bug 1290612 - XPCNativeSet::NewInstanceMutate() is always called with a non-null first argument.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68180/diff/1-2/

Comment 6

2 years ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b2a6aaf59783
XPCNativeSet::NewInstanceMutate() is always called with a non-null first argument. r=mrbkap

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b2a6aaf59783
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.