Closed Bug 1290612 Opened 6 years ago Closed 6 years ago

XPCNativeSet::NewInstanceMutate() is always called with a non-null first argument

Categories

(Core :: XPConnect, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox50 --- affected
firefox51 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

It has a single call site, which is immediately after a null check of the value passed in as the first argument. (This is fortunate, because the code that would run if the argument was null is wrong.)
This is the one callsite, in XPCNativeSet::GetNewOrUsed():

    if (otherSet)
        set = NewInstanceMutate(otherSet, newInterface, position);

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d84c376c45ad
Attachment #8776399 - Flags: review?(mrbkap) → review+
Comment on attachment 8776399 [details]
Bug 1290612 - XPCNativeSet::NewInstanceMutate() is always called with a non-null first argument.

https://reviewboard.mozilla.org/r/68180/#review65456
Thanks for the reviews. I'm going to try to rebase and push to MozReview so ignore any review requests you get. I'm not sure how this is supposed to work with MozReview...
Comment on attachment 8776399 [details]
Bug 1290612 - XPCNativeSet::NewInstanceMutate() is always called with a non-null first argument.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68180/diff/1-2/
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b2a6aaf59783
XPCNativeSet::NewInstanceMutate() is always called with a non-null first argument. r=mrbkap
https://hg.mozilla.org/mozilla-central/rev/b2a6aaf59783
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.