Closed Bug 1290656 Opened 3 years ago Closed 3 years ago

gbox is not defined in am-im.js

Categories

(Thunderbird :: Instant Messaging, defect)

x86_64
Linux
defect
Not set

Tracking

(thunderbird49 fixed, thunderbird50 fixed, thunderbird51 fixed)

RESOLVED FIXED
Thunderbird 51.0
Tracking Status
thunderbird49 --- fixed
thunderbird50 --- fixed
thunderbird51 --- fixed

People

(Reporter: aceman, Assigned: aleth)

References

Details

Attachments

(1 file)

Found when playing with IM accounts in account manager:

ReferenceError: gbox is not defined  am-im.js:93
Thanks for the catch!

Regression from https://hg.mozilla.org/comm-central/rev/2f6efb061544.
Attachment #8776709 - Flags: review?(acelists)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Regression affects TB47 and newer.
Blocks: 1237385
Comment on attachment 8776709 [details] [diff] [review]
Fix undefined gbox regression in am-im.js

Review of attachment 8776709 [details] [diff] [review]:
-----------------------------------------------------------------

I do not see what has improved now, but the error is no longer there. Thanks.
Attachment #8776709 - Flags: review?(acelists) → review+
https://hg.mozilla.org/comm-central/rev/8f3e3e2129c8d23ce5c38a1bad7b5a8d3eedee60
Bug 1290656 - Fix undefined gbox regression in am-im.js. r=aceman
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 51.0
aleth: Do we want to uplift this?
Comment on attachment 8776709 [details] [diff] [review]
Fix undefined gbox regression in am-im.js

[Approval Request Comment]
User impact if declined: Might as well uplift, simple regression fix.
Risk to taking this patch (and alternatives if risky): zero
Attachment #8776709 - Flags: approval-comm-beta?
Attachment #8776709 - Flags: approval-comm-aurora?
Attachment #8776709 - Flags: approval-comm-beta?
Attachment #8776709 - Flags: approval-comm-beta+
Attachment #8776709 - Flags: approval-comm-aurora?
Attachment #8776709 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.