1290676 - Call InsertionSort when |denseLen < 24| in MergeSort?

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[André Bargull [:anba]]

http://hg.mozilla.org/mozilla-central/file/e5859dfe0bcb/js/src/builtin/Sorting.js#l251
---
    // Insertion sort for small arrays, where "small" is defined by performance
    // testing.
    if (len < 24) {
    ....
---

Shouldn't this line check for |denseLen| instead of |len|?



And the |denseList| allocation in [1] should probably be moved after [2]. 

[1] http://hg.mozilla.org/mozilla-central/file/e5859dfe0bcb/js/src/builtin/Sorting.js#l232
[2] http://hg.mozilla.org/mozilla-central/file/e5859dfe0bcb/js/src/builtin/Sorting.js#l239

Comment 1

[Jinank Jain[:jj]]

Attachment: a1.diff

Comment 2

[Morgan Phillips [:mrrrgn]]

Comment on attachment 8778933 [details] [diff] [review]
a1.diff

Nice, thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af3c0ced9dc4
Call InsertionSort when |denseLen < 24| in MergeSort. r=mrrrgn

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/af3c0ced9dc4