TypeError: this._baseNode.contains is not a function TooltipToggle.js:157:37

VERIFIED FIXED in Firefox 50

Status

defect
VERIFIED FIXED
3 years ago
Last year

People

(Reporter: magicp.jp, Assigned: jsnajdr)

Tracking

Trunk
Firefox 51
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox49 unaffected, firefox50 verified, firefox51 verified)

Details

Attachments

(4 attachments, 1 obsolete attachment)

Posted video screen-shot.mp4
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160729030203

Steps to reproduce:

1. Start Nightly
2. Open DevTools > Network Monitor
3. Go to any sites
4. Mouse over on side-menu-widget-container


Actual results:

The following error occurs

TypeError: this._baseNode.contains is not a function TooltipToggle.js:157:37

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=212b7e507a61f1aff4db9d175fc7ca6bd2e65538&tochange=13fe047c4015a86a79e45d42413e9f7f71fddd95



Expected results:

Works without error
Blocks: 1179048
Has Regression Range: --- → yes
Has STR: --- → yes
Component: Untriaged → Developer Tools: Netmonitor
OS: Unspecified → All
Hardware: Unspecified → All
Another error message is displayed by mouse over on the breadcrumbs in Inspector.

TypeError: this.handleMouseLeave is not a function breadcrumbs.js:486:7
The _baseNode passed to Tooltip.startTogglingOnHover at [1] is not a Node, but a widget object.

[1] http://searchfox.org/mozilla-central/source/devtools/client/netmonitor/netmonitor-view.js#478
Assignee: nobody → jsnajdr
Pass the widget's parent node to startTogglingOnHover. The SideMenuWidget component forwards some methods (addEventListener, getAttribute) to the node, but not all.
Attachment #8776905 - Flags: review?(jdescottes)
Comment on attachment 8776905 [details] [diff] [review]
Netmonitor mousemove throws TypeError: this._baseNode.contains is not a function

Review of attachment 8776905 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks for working on this!
Attachment #8776905 - Flags: review?(jdescottes) → review+
(In reply to Julian Descottes [:jdescottes] (on PTO, back 4th of August) from comment #5)
> Looks good to me, thanks for working on this!

Thanks for the review! Before we land this, I'd also like to add a test for the case when the mouse cursor leaves the baseNode. We'll be uplifting this to aurora, so it's better be covered.
There is no test for the TooltipToggle functionality, so I added one.
Attachment #8778842 - Flags: review?(jdescottes)
Added a test for leaving the widget to browser_net_image-tooltip.js that would have caught this bug.
Attachment #8778843 - Flags: review?(jdescottes)
Comment on attachment 8778842 [details] [diff] [review]
Add test coverage for TooltipToggle on HTMLTooltip

Review of attachment 8778842 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for the new test!

::: devtools/client/shared/test/browser_html_tooltip_hover.js
@@ +4,5 @@
> +
> +"use strict";
> +
> +/**
> + * Test the TooltipToogle helper class for HTMLTooltip

nit : TooltipToogle -> TooltipToggle
Attachment #8778842 - Flags: review?(jdescottes) → review+
Comment on attachment 8778843 [details] [diff] [review]
Test the mouse leaving the widget in browser_net_image-tooltip.js

Review of attachment 8778843 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Attachment #8778843 - Flags: review?(jdescottes) → review+
Fixed the typo (Toogle/Toggle)
Attachment #8778895 - Flags: review+
Attachment #8778842 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/d7218029d78d
Netmonitor mousemove throws TypeError: this._baseNode.contains is not a function r=jdescottes
https://hg.mozilla.org/integration/fx-team/rev/9ccc7eb9a74c
Test the mouse leaving the widget in browser_net_image-tooltip.js r=jdescottes
https://hg.mozilla.org/integration/fx-team/rev/3e4803eb9a5c
Add test coverage for TooltipToggle on HTMLTooltip r=jdescottes
Keywords: checkin-needed
Comment on attachment 8776905 [details] [diff] [review]
Netmonitor mousemove throws TypeError: this._baseNode.contains is not a function

Approval Request Comment
[Feature/regressing bug #]: 1179048
[User impact if declined]: Hovering mouse in NetMonitor request list with throw JS exceptions, displaying popups won't work well.
[Describe test coverage new/current, TreeHerder]: Added two new tests to test the regressed part of the feature
[Risks and why]: low, obvious 2-line patch with new tests added.
[String/UUID change made/needed]: none
Attachment #8776905 - Flags: approval-mozilla-aurora?
Comment on attachment 8778843 [details] [diff] [review]
Test the mouse leaving the widget in browser_net_image-tooltip.js

Approval Request Comment: see attachment 8776905 [details] [diff] [review]
Attachment #8778843 - Flags: approval-mozilla-aurora?
Comment on attachment 8778895 [details] [diff] [review]
Add test coverage for TooltipToggle on HTMLTooltip

Approval Request Comment: see attachment 8776905 [details] [diff] [review]
Attachment #8778895 - Flags: approval-mozilla-aurora?
I have reproduced this bug with Nightly 50.0a1 (2016-07-30) on Windows 7, 64 Bit!

This bug's fix is verified with latest Nightly 

 Build ID    20160816030459
 User Agent  Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0
I have reproduced this bug with Nightly 50.0a1 (2016-07-30) on Ubuntu 14.04, 64 bit!

The bug's fix is now verified on latest Nightly 51.0a1.

Nightly 51.0a1:
Build ID 	20160818030226
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160817]
Status: RESOLVED → VERIFIED
Comment on attachment 8776905 [details] [diff] [review]
Netmonitor mousemove throws TypeError: this._baseNode.contains is not a function

Fix was verified on Nightly, Aurora50+
Attachment #8776905 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8778843 [details] [diff] [review]
Test the mouse leaving the widget in browser_net_image-tooltip.js

Test-only patches don't need relman review, they are auto-approved.
Attachment #8778843 - Flags: approval-mozilla-aurora?
Attachment #8778895 - Flags: approval-mozilla-aurora?
verified in 50. Thanks!
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.