1290681 - Remove the single color optimization from imgFrame

Status: RESOLVED FIXED

(Core :: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

The results for bug 1281680 show that imgFrame's single color optimization is not useful. It's downright harmful to keep it around, since it complicates the code and it no test coverage (we disable it for reftests because of its tendency to cause intermittent oranges). Let's remove it.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: (Part 1) - Remove telemetry for the single color optimization.

This yanks out the telemetry that was added in bug 1281680 for the single color
optimization, since it has served its purpose at this point.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Attachment: (Part 2) - Remove the single color optimization from imgFrame.

This rips out the code that implements the single color optimization.

Comment 3

[Seth Fowler [:seth] [:s2h]]

Attachment: (Part 3) - Remove the single color optimization pref.

This removes the pref that we used to control whether the single color
optimization got applied.

Comment 4

[Seth Fowler [:seth] [:s2h]]

Try job here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a8d45e5f86d

Comment 5

[Seth Fowler [:seth] [:s2h]]

Thanks for the quick reviews, Edwin!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2597f37b8acc
(Part 1) - Remove telemetry for the single color optimization. r=edwin
https://hg.mozilla.org/integration/mozilla-inbound/rev/078d914cde9a
(Part 2) - Remove the single color optimization from imgFrame. r=edwin
https://hg.mozilla.org/integration/mozilla-inbound/rev/37767b4aa169
(Part 3) - Remove the single color optimization pref. r=edwin

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2597f37b8acc
https://hg.mozilla.org/mozilla-central/rev/078d914cde9a
https://hg.mozilla.org/mozilla-central/rev/37767b4aa169