Closed Bug 1290681 Opened 3 years ago Closed 3 years ago

Remove the single color optimization from imgFrame

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: seth, Assigned: seth)

References

Details

Attachments

(3 files)

The results for bug 1281680 show that imgFrame's single color optimization is not useful. It's downright harmful to keep it around, since it complicates the code and it no test coverage (we disable it for reftests because of its tendency to cause intermittent oranges). Let's remove it.
Blocks: 1290682
This yanks out the telemetry that was added in bug 1281680 for the single color
optimization, since it has served its purpose at this point.
Attachment #8776315 - Flags: review?(edwin)
This rips out the code that implements the single color optimization.
Attachment #8776316 - Flags: review?(edwin)
This removes the pref that we used to control whether the single color
optimization got applied.
Attachment #8776317 - Flags: review?(edwin)
Thanks for the quick reviews, Edwin!
Pushed by seth.bugzilla@blackhail.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2597f37b8acc
(Part 1) - Remove telemetry for the single color optimization. r=edwin
https://hg.mozilla.org/integration/mozilla-inbound/rev/078d914cde9a
(Part 2) - Remove the single color optimization from imgFrame. r=edwin
https://hg.mozilla.org/integration/mozilla-inbound/rev/37767b4aa169
(Part 3) - Remove the single color optimization pref. r=edwin
You need to log in before you can comment on or make changes to this bug.