Closed Bug 1290696 Opened 3 years ago Closed 3 years ago

Today pane highlighted task difficult to read.

Categories

(Calendar :: OS Integration, defect)

x86
Windows 10
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: unicorn.consulting, Assigned: Paenglab)

Details

Attachments

(2 files, 2 obsolete files)

When selecting a task in the task list on the today pane, the highlighted task is difficult to read as the colour is white on pale blue.

I am assuming my theme settings are fairly standard for windows 10 and Thunderbird theme is most assuredly the default
Attached patch highlight.patch (obsolete) — Splinter Review
Windows Vista and up needs a special treeitem text treatment when selected focus because of the light background.

I also fixed the text alignment where the tak title text is too hight placed to the progress text. This applies on all platforms.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8776370 - Flags: review?(makemyday)
Does that fit also for overdue tasks, when the bg color changes to red?
The background is always the light blue. Before patch the text is white and after patch black. I could add a rule to make the text red. Also in Task tab's tree the text isn't red when selected.
This is a regression. This has been working that way for TB 45 - at least on Win7.
Attached patch highlight.patch (obsolete) — Splinter Review
Fixed the overdue color. Made the same to the inprogress state. But what is needed to see this green color? I have tasks with 50% completed but never see this green. The same on Linux.
Attachment #8776370 - Attachment is obsolete: true
Attachment #8776370 - Flags: review?(makemyday)
Attachment #8776372 - Flags: review?(makemyday)
Comment on attachment 8776372 [details] [diff] [review]
highlight.patch

Review of attachment 8776372 [details] [diff] [review]:
-----------------------------------------------------------------

r- for the color issue.

::: calendar/base/themes/common/calendar-task-tree.css
@@ +13,5 @@
> +/* align the treechildren text */
> +.calendar-task-tree > treechildren::-moz-tree-cell-text {
> +  margin-top: 1px;
> +  margin-bottom: 1px;
> +}

Indentation. Please use 4 whitespaces.

::: calendar/base/themes/windows/calendar-task-tree.css
@@ +39,5 @@
> +
> +        .calendar-task-tree > treechildren::-moz-tree-cell-text(overdue, selected, focus) {
> +            color: red;
> +        }
> +    }

I think you just have to make sure to persist the status quo for inprogress and overdue, which is white/light text color on dark background (red/green) when the item is selected. The red/green text color is appropriate for not selected items as is (seen on Win 7).

To get the green color to show up, you need a task with a startdate before now. But it seems the tree item decoration doesn't get updated accordingly after changing an item. After closing and reopening the respective tab, it seems to appear for me.
Attachment #8776372 - Flags: review?(makemyday) → review-
Attached patch highlight.patchSplinter Review
You're right, let the background be green or red is better.
Attachment #8776372 - Attachment is obsolete: true
Attachment #8776392 - Flags: review?(makemyday)
Comment on attachment 8776392 [details] [diff] [review]
highlight.patch

Review of attachment 8776392 [details] [diff] [review]:
-----------------------------------------------------------------

Look good now, thanks.
Attachment #8776392 - Flags: review?(makemyday) → review+
http://hg.mozilla.org/comm-central/rev/bb38f0bb0257
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 5.2
Comment on attachment 8776392 [details] [diff] [review]
highlight.patch

This is a regression and should land on ESR 45
Attachment #8776392 - Flags: approval-calendar-esr?(philipp)
Attachment #8776392 - Flags: approval-calendar-beta?(philipp)
Attachment #8776392 - Flags: approval-calendar-aurora?(philipp)
Attachment #8776392 - Flags: approval-calendar-esr?(philipp)
Attachment #8776392 - Flags: approval-calendar-esr+
Attachment #8776392 - Flags: approval-calendar-beta?(philipp)
Attachment #8776392 - Flags: approval-calendar-beta+
Attachment #8776392 - Flags: approval-calendar-aurora?(philipp)
Attachment #8776392 - Flags: approval-calendar-aurora+
Keywords: checkin-needed
Whiteboard: checked-in on v 5.2
As this patch is currently already on Aurora, it will be promoted automatically to beta with the merge tomorrow. So it only need to be checked-in on ESR.
Whiteboard: checked-in on v 5.2 → [checkin-needed: ESR only]
https://hg.mozilla.org/releases/comm-beta/rev/555845fa3750c03c5c7dc90c8fbfa0ac65f5c2c2
https://hg.mozilla.org/releases/comm-esr45/rev/3e509a19b6bfb5da72e997e0b54dcfb254eeb2d5

The target milestone still needs to be updated once available - see whiteboard.
Keywords: checkin-needed
Whiteboard: [checkin-needed: ESR only] → [update target milestone to 4.7.4]
Target Milestone: 5.2 → 5.1
Whiteboard: [update target milestone to 4.7.4]
Target Milestone: 5.1 → 4.7.4
Never landed on releases/comm-aurora, so it will forever show up in my search for bugs with approval and without landing. This fake comment fixes that.
You need to log in before you can comment on or make changes to this bug.