1290749 - Skip plugin content plugin of no URI specified

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Tobias Schneider [:tobytailor]]

If no URI is given for plugin content (this happens mostly in tests), skip content blocking check.

Comment 1

[Tobias Schneider [:tobytailor]]

Attachment: Skip plugin content blocking if no URI specified

Comment 2

[Tobias Schneider [:tobytailor]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7821f7ff201f

Comment 3

[Tobias Schneider [:tobytailor]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b325f9a8a68
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc694d85ef1a

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f66d9a52316
Skip plugin content plugin of no URI specified. r=francois

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0f66d9a52316

Comment 6

[Tobias Schneider [:tobytailor]]

Comment on attachment 8776400 [details] [diff] [review]
Skip plugin content blocking if no URI specified

Approval Request Comment
[Feature/regressing bug #]: Non-essential plugin blocking: reduces plugin crash rate by 5-10%
[User impact if declined]: more plugin crashes/hangs
[Describe test coverage new/current, TreeHerder]: tests already landed, were broken with e10s and this patch fixes
[Risks and why]: Pretty low risk: a little refactoring, and plugins are never 100% risk-free, but 
[String/UUID change made/needed]: None

This needs to land along with bug 1275591 which actually turns the feature on.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8776400 [details] [diff] [review]
Skip plugin content blocking if no URI specified

Let's bring this to aurora since the patch from bug 1275591 is already on 50.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4d51664244aa

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8776400 [details] [diff] [review]
Skip plugin content blocking if no URI specified

Bring down plugin crashes, let's take this on beta. Once it lands we can also land the patch from bug 1275591.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/d864c2b49174