Skip plugin content plugin of no URI specified

RESOLVED FIXED in Firefox 49

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tschneider, Assigned: tschneider)

Tracking

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox48 wontfix, firefox49 fixed, firefox50 fixed, firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
If no URI is given for plugin content (this happens mostly in tests), skip content blocking check.
(Assignee)

Comment 1

2 years ago
Created attachment 8776400 [details] [diff] [review]
Skip plugin content blocking if no URI specified
(Assignee)

Updated

2 years ago
Blocks: 1275591
status-firefox48: --- → wontfix
status-firefox49: --- → ?
status-firefox50: --- → ?
status-firefox51: --- → affected
(Assignee)

Updated

2 years ago
Attachment #8776400 - Flags: review?(francois)
Attachment #8776400 - Flags: review?(francois) → review+
Assignee: nobody → tschneider
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f66d9a52316
Skip plugin content plugin of no URI specified. r=francois
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0f66d9a52316
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
(Assignee)

Comment 6

2 years ago
Comment on attachment 8776400 [details] [diff] [review]
Skip plugin content blocking if no URI specified

Approval Request Comment
[Feature/regressing bug #]: Non-essential plugin blocking: reduces plugin crash rate by 5-10%
[User impact if declined]: more plugin crashes/hangs
[Describe test coverage new/current, TreeHerder]: tests already landed, were broken with e10s and this patch fixes
[Risks and why]: Pretty low risk: a little refactoring, and plugins are never 100% risk-free, but 
[String/UUID change made/needed]: None

This needs to land along with bug 1275591 which actually turns the feature on.
Attachment #8776400 - Flags: approval-mozilla-beta?
Attachment #8776400 - Flags: approval-mozilla-aurora?
Comment on attachment 8776400 [details] [diff] [review]
Skip plugin content blocking if no URI specified

Let's bring this to aurora since the patch from bug 1275591 is already on 50.
Attachment #8776400 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 8

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/4d51664244aa
status-firefox50: ? → fixed
Comment on attachment 8776400 [details] [diff] [review]
Skip plugin content blocking if no URI specified

Bring down plugin crashes, let's take this on beta. Once it lands we can also land the patch from bug 1275591.
Attachment #8776400 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 10

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/d864c2b49174
status-firefox49: ? → fixed
You need to log in before you can comment on or make changes to this bug.