Closed Bug 1290759 Opened 3 years ago Closed 3 years ago

Convert the sketchy frame number check in Decoder::AllocateFrame() into an assert

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: seth, Assigned: seth)

References

Details

Attachments

(1 file)

See bug 1290747 comment 4. There's a sketchy frame number check in Decoder::AllocateFrame(). This frame number check is an artifact from ancient times, and what's troubling about it is that it could prevent us from running assertions that we really should be running at all times. If that check fails, it's a bug, so let's just convert it into an assertion and prevent silent failures that could introduce harder-to-debug issues elsewhere.
Pushed by seth.bugzilla@blackhail.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d668735beb3
Convert frame number check in Decoder::AllocateFrame() into an assert. r=edwin
https://hg.mozilla.org/mozilla-central/rev/9d668735beb3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.