Closed Bug 1290789 Opened 8 years ago Closed 8 years ago

firefox_primary_builds.json should have release and beta values for en-US

Categories

(Release Engineering :: Applications: Shipit, defect)

Product:
Release Engineering
Component:
Applications: Shipit
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: pascalc, Assigned: pascalc)

References

Details

Attachments

(1 file)

Patch on GitHub
49 bytes, text/x-github-pull-request
Sylvestre
: review+
Details | Review 
see https://bugzilla.mozilla.org/show_bug.cgi?id=1282494#c21

The data we have in firefox_primary_builds.json is correct for all locales but release and beta values are missing for en-US. This is because these values are populated in generateLocalizedBuilds() based on an l10n changeset provided by ship it and en-US doesn't have one.

An easy fix is to add en-US by default to the dict in this function with an artificial changeset.
Assignee: nobody → pascalc
Attached file Patch on GitHub — 

        Attachment #8776456 -
        Flags: review?(sledru)

    
    

    
  
Comment on attachment 8776456 [details] [review]
Patch on GitHub

good, thanks :)

        Attachment #8776456 -
        Flags: review?(sledru) → review+

    
    

    
  
Fixed: https://product-details.mozilla.org/1.0/firefox_primary_builds.json
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: Applications: ShipIt (backend) → Applications: ShipIt

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: