Closed
Bug 1290806
Opened 5 years ago
Closed 5 years ago
[e10s] Intermittent test_window_management.py TestSwitchWindow.test_windows | AssertionError: 1 != 2
Categories
(Testing :: Marionette, defect)
Tracking
(e10s+, firefox49 wontfix, firefox50 fixed, firefox51 fixed)
RESOLVED
FIXED
mozilla51
People
(Reporter: intermittent-bug-filer, Assigned: whimboo)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
Filed by: tomcat [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=4520983&repo=mozilla-central http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-linux64/1469888546/mozilla-central_ubuntu64_vm_test-marionette-e10s-bm116-tests1-linux64-build0.txt.gz
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 8•5 years ago
|
||
Orange Factor says that this failure is e10s only: 16:02:35 ERROR - TEST-UNEXPECTED-FAIL | test_window_management.py TestSwitchWindow.test_windows | AssertionError: 1 != 2 16:02:35 INFO - Traceback (most recent call last): 16:02:35 INFO - File "/builds/slave/test/build/venv/lib/python2.7/site-packages/marionette/marionette_test.py", line 365, in run 16:02:35 INFO - testMethod() 16:02:35 INFO - File "/builds/slave/test/build/tests/marionette/tests/testing/marionette/harness/marionette/tests/unit/test_window_management.py", line 44, in test_windows 16:02:35 INFO - self.assertEqual(len(now_available), len(orig_available) + 1) 16:02:35 INFO - TEST-INFO took 1502ms Looks also to be a race given that we do not wait for the new window to open.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
tracking-e10s:
--- → ?
OS: Unspecified → All
Hardware: Unspecified → All
Summary: Intermittent test_window_management.py TestSwitchWindow.test_windows | AssertionError: 1 != 2 → [e10s] Intermittent test_window_management.py TestSwitchWindow.test_windows | AssertionError: 1 != 2
Updated•5 years ago
|
Blocks: e10s-tests
Comment hidden (mozreview-request) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•5 years ago
|
Attachment #8789442 -
Flags: review?(ato) → review?(mjzffr)
Comment 11•5 years ago
|
||
mozreview-review |
Comment on attachment 8789442 [details] Bug 1290806 - Fix TestSwitchWindow.test_windows by waiting for the newly opened window. https://reviewboard.mozilla.org/r/77660/#review77176 r+wc ::: testing/marionette/harness/marionette/tests/unit/test_window_management.py:44 (Diff revision 1) > self.open_new_window() > #assert we're still in the original window > self.assertEqual(self.marionette.current_window_handle, orig_win) > now_available = self.marionette.window_handles > #assert we can find the new window > - self.assertEqual(len(now_available), len(orig_available) + 1) > + Wait(self.marionette).until(lambda _: len(now_available) == len(orig_available) + 1) Add a `message` parameter to `until` -- otherwise the only failure info we'll get in the log will be "lambda"
Updated•5 years ago
|
status-firefox49:
--- → unaffected
status-firefox50:
--- → affected
status-firefox51:
--- → affected
Assignee | ||
Updated•5 years ago
|
Attachment #8789442 -
Flags: review?(dburns)
Assignee | ||
Updated•5 years ago
|
Attachment #8789442 -
Flags: review?(dburns)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 13•5 years ago
|
||
mozreview-review |
Comment on attachment 8789442 [details] Bug 1290806 - Fix TestSwitchWindow.test_windows by waiting for the newly opened window. https://reviewboard.mozilla.org/r/77660/#review77212
Comment 14•5 years ago
|
||
mozreview-review |
Comment on attachment 8789442 [details] Bug 1290806 - Fix TestSwitchWindow.test_windows by waiting for the newly opened window. https://reviewboard.mozilla.org/r/77660/#review77262
Attachment #8789442 -
Flags: review?(mjzffr) → review+
Comment hidden (mozreview-request) |
Comment 16•5 years ago
|
||
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f282dae81f23 Fix TestSwitchWindow.test_windows by waiting for the newly opened window. r=maja_zf
Comment 17•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f282dae81f23
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee | ||
Comment 18•5 years ago
|
||
Even branches earlier than aurora should be affected, but we are not going to fix those. Aurora will just be fine.
Whiteboard: [checkin-needed-aurora]
Comment 19•5 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/6b9c6e4a0577
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•