Reduce the amount of calls upon the first find action

RESOLVED FIXED in Firefox 51

Status

()

Toolkit
Find Toolbar
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mikedeboer, Assigned: mikedeboer)

Tracking

(Blocks: 1 bug)

50 Branch
mozilla51
Points:
3
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox50 affected, firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Now that we have a FinderHighlighter class, we can reduce the amount of calls we make to render the dimmed layer and the rectangles within it.

There's also some redundant highlight-all logic in the findbar binding that should be factored out.
Flags: qe-verify-
Flags: firefox-backlog+
(Assignee)

Comment 1

2 years ago
Created attachment 8776546 [details]
Bug 1290842 - reduce the amount calls to the highlighter upon the first find action and improve the behavior when modal highlighting is not enabled now that we have a FinderHighlighter class we can use.

Review commit: https://reviewboard.mozilla.org/r/68292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68292/
Attachment #8776546 - Flags: review?(jaws)
Comment on attachment 8776546 [details]
Bug 1290842 - reduce the amount calls to the highlighter upon the first find action and improve the behavior when modal highlighting is not enabled now that we have a FinderHighlighter class we can use.

https://reviewboard.mozilla.org/r/68292/#review65386
Attachment #8776546 - Flags: review?(jaws) → review+
(Assignee)

Comment 4

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/46045ec8a4aa09a341b7209170089ade3c27c1a5
Bug 1290842 - reduce the amount calls to the highlighter upon the first find action and improve the behavior when modal highlighting is not enabled now that we have a FinderHighlighter class we can use. r=jaws

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/46045ec8a4aa
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51

Updated

2 years ago
Depends on: 1294644

Updated

2 years ago
Blocks: 1306320
(Assignee)

Updated

2 years ago
No longer blocks: 1306320
You need to log in before you can comment on or make changes to this bug.