1290906 - [pushes][shipping] Don't use 'default' when referring to hg revisions, at least not when touching itsefl

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect)

Description

[Axel Hecht [:Pike]]

As we want unified repos (bug 1137666), we need to get rid of all use-cases for "default" as a value to pass in to mercurial. That'd generate random results.

Things like "default branch of a changeset is default", though, are fine.

Also, using "default" in URLs, at least as long as we have a single-non-unified repository in there.

To replace "default", use the last revision on the default branch pushed to the non-unified repo.

Comment 1

[Axel Hecht [:Pike]]

We're using 'default' quite a bit in locale-inspector and friends, but within elmo, it seems that shipping-json_changesets is the only offender.

Also, I handed out urls to teh diff view that include 'default', and possibly even tip, so let's fix those up, too.

Comment 2

[Axel Hecht [:Pike]]

Attachment: Replace 'default' from the hg repo with one from the db

Rail, I'd like someone from releng to know that this is happening, and understood on your side of things. Are you a good candidate for that?

This is where things play in:

As part of updating the local repos, I'm also updating the local database. So right now, the latest head on 'default' would also be the latest changeset on the 'default' branch in the db.

In this context, this is only going to speed things up, as resolving 'default' in hg does all kinds of updates to branch and tag caches :-/

I also want to start using unified repos locally, to reduce storage cost etc. So this unblocks that part.

I quickly glanced at ship-it, to see if it was easy for ship-it to request a specific revision, but that's non-trivial, and probably creates more problems on out-of-band stuff.

This should improve things while we're waiting for the better fix from bug 1280730

Comment 3

[[github robot]]

Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/be35810ad4eef7d9c127d1dbde294293b60e618d
bug 1290906, resolve default or tip to the last known default changeset in the db, r=rail

Resolving 'default' is slow, and as soon as we use unified repos on elmo, also
wrong. Let's pick the last changeset of the default branch from the db, and use
an explicit version when talking to hg.
I'm also aliasing this to tip, which is not strictly true always, but it
shouldn't be used to begin with.
Better fix would be to just not have this code path at all, which is
bug 1280730.

Comment 4

[[github robot]]

Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/f1272f64310c2bcb99195b088f274ac5dcd718d3
bug 1290906, add support for 'default' and 'tip' as arguments to the diff view

As usual, supporting 'tip' is not all that useful, but let's run with it.

Comment 5

[Axel Hecht [:Pike]]

https://github.com/Pike/master-ball/commit/bf34952a31aa3b231c15e9d724f2ac2190e8f8cb is really this bug.
Also https://github.com/Pike/master-ball/commit/e75b9f8220843f63d07f21b0295adade8801f0b7 on masterball.