releasetasks_graph_gen.py get_partials is passed an unexpected string of partials

RESOLVED FIXED

Status

Release Engineering
Release Automation
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jlund, Assigned: jlund)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

a year ago
(releaserunner)[cltbld@buildbot-master85.bb.releng.scl3.mozilla.com release]$ hg diff
diff --git a/buildfarm/release/releasetasks_graph_gen.py b/buildfarm/release/releasetasks_graph_gen.py
--- a/buildfarm/release/releasetasks_graph_gen.py
+++ b/buildfarm/release/releasetasks_graph_gen.py
@@ -33,6 +33,8 @@ def main(release_runner_config, release_
     rr = ReleaseRunner(api_root=api_root, username=username, password=password)
     graph_id = slugId()
     log.info('Generating task graph')
+    log.info("using config:")
+    log.info(release_config)
     kwargs = {
         # release-runner.ini
         "signing_pvt_key": release_config['signing_pvt_key'],
diff --git a/lib/python/kickoff/__init__.py b/lib/python/kickoff/__init__.py
--- a/lib/python/kickoff/__init__.py
+++ b/lib/python/kickoff/__init__.py
@@ -134,6 +134,8 @@ def get_partials(rr, partial_versions, p
         return partials
     for p in partial_versions.split(','):
         partialVersion, buildNumber = p.split('build')
+        print "XXX"
+        print partialVersion
         partial_release_name = '{}-{}-build{}'.format(
             product.capitalize(), partialVersion, buildNumber,
         )

shows me that partials equals:
'partials': u'47.0build3, 47.0.1build1, 48.0b10build1',

and so we end up with " 47.0.1" here:
XXX
 47.0.1
Traceback (most recent call last):
  File "releasetasks_graph_gen.py", line 216, in <module>
    main(release_runner_config, releasetasks_kwargs, tc_config)
  File "releasetasks_graph_gen.py", line 89, in main
    release_config['product']),
  File "/builds/releaserunner/tools/lib/python/kickoff/__init__.py", line 143, in get_partials
    'appVersion': getAppVersion(partialVersion),
  File "/builds/releaserunner/tools/lib/python/release/versions.py", line 7, in getAppVersion
    return re.match(ANY_VERSION_REGEX, version).group(1)
AttributeError: 'NoneType' object has no attribute 'group'
(Assignee)

Comment 2

a year ago
Created attachment 8776606 [details] [diff] [review]
160801_bug_1290918.patch
Attachment #8776606 - Flags: review?(mtabara)
Attachment #8776606 - Flags: review?(mtabara) → review+
(Assignee)

Updated

a year ago
Summary: releasetasks_graph_gen.py get_partials is passed a string of partials from common taskid with spaces in it → releasetasks_graph_gen.py get_partials is passed an unexpected string of partials
(Assignee)

Updated

a year ago
Assignee: nobody → jlund
(Assignee)

Comment 3

a year ago
https://hg.mozilla.org/build/tools/rev/3ea759ccbbd12c3a60db69fa5910f9cc41de0df7
Bug 1290918 - releasetasks_graph_gen.py get_partials is passed an unexpected string of partials, r=mtabara
Created attachment 8776621 [details] [review]
releastasks part - trim trailing spaces when recreating partials list for graph2

https://github.com/mozilla/releasetasks/pull/189

Eliminating the root of evil here.
Partials list comes nicely in the form of "X,Y,Z" from Ship-it; it gets processed in graph1 and stashed in the common_extras for graph2. While building the partials for graph2, I've accidentally added a trailing space for the string joiner there in bug 1278312. Correcting that mistake.
Attachment #8776621 - Flags: review?(rail)
Attachment #8776621 - Flags: review?(rail) → review+
Comment on attachment 8776621 [details] [review]
releastasks part - trim trailing spaces when recreating partials list for graph2

https://github.com/mozilla/releasetasks/commit/db48ca10cdc37191ca96d54189df0405b88a0378
Attachment #8776621 - Flags: checked-in+
deployed
Found this is triage. I think we can close it unless we want to wait for 49 RC to double check my patch. Jlund's patch was checked before 48.0 RC
(Assignee)

Comment 8

a year ago
yep :)
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.