test_non_ascii_paths fails under VirtualBox on Mac host

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: erik, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: easy python)

(Reporter)

Description

3 years ago
The important part of the error message is this:

Build command for 'code' failed, exited non-zero.
Log follows:
    | rm -rf code
    | mkdir code
    | cd code && python -c "import os; os.mkdir('\x8d\xae\xa2\xa0\xef')"
    | Traceback (most recent call last):
    |   File "<string>", line 1, in <module>
    | OSError: [Errno 71] Protocol error: '\x8d\xae\xa2\xa0\xef'
    | make: *** [all] Error 1

There's something unsupported about creating the folder with the icky name in a shared folder. It works fine in the (unshared) ~dxr home dir. It also works fine on a Linux-hosted docker container, which is how our Travis tests pass.
(Reporter)

Comment 1

3 years ago
Putting ENV LC_ALL=C.UTF-8 LANG=C.UTF-8 in the Dockerfile avails not.
(Reporter)

Comment 2

3 years ago
It's probably HFS+ getting mad about non-UTF-decodeable byte sequences in the names. We'll have to have the test machinery copy the code to be indexed to a non-shared dir first.
(Reporter)

Updated

3 years ago
Whiteboard: easy python
(Reporter)

Comment 3

2 years ago
It's test_unicode that fails now. We either moved the tests, or the initial report was mistaken.
(Reporter)

Comment 4

2 years ago
Fixed in https://github.com/mozilla/dxr/commit/a4f5f3951148303715908641acf9a684256400d6.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.