Closed Bug 1290957 Opened 4 years ago Closed 4 years ago

fail the build if MOZ_AUTOMATION and not MOZ_CARGO_SUPPORTS_FROZEN

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

Our automation builds should always be using the --frozen flag to 'cargo build'; we should fail builds if it turns out that flag isn't supported by the version of cargo that we're using (or the check is buggy in some way).
We want to ensure that our automation builds don't pull in libraries
from crates.io, and we need --frozen support in cargo to do that.  If we
don't have that support, we shouldn't build.
Attachment #8778948 - Flags: review?(cmanchester)
Assignee: nobody → nfroyd
Attachment #8778948 - Flags: review?(cmanchester) → review+
Summary: fail the build if MOZ_AUTOMATION and MOZ_CARGO_SUPPORTS_FROZEN → fail the build if MOZ_AUTOMATION and not MOZ_CARGO_SUPPORTS_FROZEN
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8be3efb3486
ensure MOZ_AUTOMATION builds require a cargo with --frozen support; r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/c8be3efb3486
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.