1290962 - "Update Firefox" story doesn't retain the locale between "scenes"

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[alex_mayorga]

¡Hola!

From https://bugzilla.mozilla.org/show_bug.cgi?id=1281144#c4

"Update Firefox" story doesn't retain the locale between "scenes" or something.

Steps:
- Load https://www.mozilla.org/es-MX/firefox/new/ 
- Click "Descarga gratuita"

Result:
Loads https://www.mozilla.org/en-US/firefox/new/?scene=2 and from there the download link is en-US too https://download.mozilla.org/?product=firefox-stub&os=win&lang=en-US

Expected result:
Loads https://www.mozilla.org/es-MX/firefox/new/?scene=2 and from there the download link is too https://download.mozilla.org/?product=firefox-stub&os=win&lang=es-MX

Comment 1

[Francesco Lodolo [:flod]]

There's one thing unclear: can you clarify what you mean with "Update Firefox story"? Is it not just opening firefox/new?

Comment 2

[Alex Gibson [:agibson]]

Because the /firefox/new/ template is two separate URL's, clicking "Descarga gratuita" will redirect (like most bedrock pages do) to whatever is the users preferred language in the accept-language header.

Comment 3

[Alex Gibson [:agibson]]

The URL of the download button on /new is: 

https://www.mozilla.org/firefox/new/?scene=2 (missing the locale, which is then handled by bedrock).

Comment 4

[alex_mayorga]

Ciao flod!

Given this has "scenes" I figured it was trying to tell a "story", please excuse me if that's not the case.

¡Hola Alex!

I find jarring that it jumps from what is typed into the URL to something else or nothing.

A user complaint of getting es-ES when he was looking for es-MX for example is at  https://twitter.com/sergiodnila/status/756345047163998208

might it all be due to the fact that /all and /new have no l10n?

Comment 5

[Alex Gibson [:agibson]]

(In reply to alex_mayorga from comment #4)
> Ciao flod!
> 
> Given this has "scenes" I figured it was trying to tell a "story", please
> excuse me if that's not the case.
> 
> ¡Hola Alex!
> 
> I find jarring that it jumps from what is typed into the URL to something
> else or nothing.
> 
> A user complaint of getting es-ES when he was looking for es-MX for example
> is at  https://twitter.com/sergiodnila/status/756345047163998208
> 
> might it all be due to the fact that /all and /new have no l10n?

I'm not sure what you mean by /all and /new having no l10n, both pages are fully translated into many locales. As explained, the redirect happens because es-MX is not set as your preferred language. The reason for this I believe is that some pages on mozorg are not translated into every possible language. If we made all the download buttons point to /%LOCALE%/firefox/new/?scene=2, then it would not be possible for users to download Firefox in their preferred language from many pages.

We could possibly make an exception here for this one page, but I'm yet quite clear on what we would need to do to accommodate this exception. Some new piece of logic in the download button helper would probably be needed (assuming it does not already exist).

Comment 6

[Alex Gibson [:agibson]]

(In reply to Alex Gibson [:agibson] from comment #5)
> I'm not sure what you mean by /all and /new having no l10n, both pages are
> fully translated into many locales. As explained, the redirect happens
> because es-MX is not set as your preferred language. The reason for this I
> believe is that some pages on mozorg are not translated into every possible
> language. If we made all the download buttons point to
> /%LOCALE%/firefox/new/?scene=2, then it would not be possible for users to
> download Firefox in their preferred language from many pages.

Slight correction - /new is translated into many locales, but /all is not. Either way, /all doesn't have anything to do with this issue described here.

Comment 8

[Kohei Yoshino [:kohei]]

I think the /firefox/new/ link should be fixed anyway to avoid any confusion.

Comment 9

[Alex Gibson [:agibson]]

(In reply to Kohei Yoshino [:kohei] from comment #8)
> I think the /firefox/new/ link should be fixed anyway to avoid any confusion.

Agree, this would cause issues doing it for all download buttons. But doing it for /new/ should be OK since it is translated in so many languages.

Comment 12

[Gion-Andri Cantieni [:gion-andri]]

Are there any news on this topic? 

For Romansh (rm) this topic is very important, as there are no operation systems in Romansh and no user will visit the Mozilla website the first time with a user-agent stating he prefers Romansh. 

I think it is very important, that a user on a website in a specific language, that clicks the button in that language, gets also the download in that language and not a random one.

Comment 13

[Paul [:pmac] McLanahan]

No news yet, but we hope to have it fixed soon.

To be clear, the user's operating system has nothing to do with the language selection on the website. Browsers allow you to set your preferred language, which is sent to the website in an "Accept-Language" header. So a user could add "rm" to that if they were interested in reading the web in Romansh. mozilla.org would use that to show them pages in Romansh where avilable. And so even if they don't have that set, the build of Firefox they get isn't "random", but is based on those browser language settings and not on the page they're viewing.

We'll have it fixed soon, but I just wanted everyone to be clear on the current situation. Thanks!

Comment 14

[Gion-Andri Cantieni [:gion-andri]]

Do you have any estimation, when this bug will be fixed?

Comment 15

[Paul [:pmac] McLanahan]

Apologies. We need to bump the priority on this. I'll try to get to it early this week.

Comment 16

[Paul [:pmac] McLanahan]

Attachment: Link to Github pull-request: https://github.com/mozilla/bedrock/pull/4770

Comment 17

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/025593f7d058ca632f3553b35ec9dba03518b665
Fix bug 1290962: Include locale in Fx download scene2 URL

Add option to download_firefox helper to include the locale
in the URL for the scene2 page.

https://github.com/mozilla/bedrock/commit/30f4eeb2268166e1076556175b9e51e2163ea211
Merge pull request #4770 from pmac/include-locale-fx-download-scene1-1290962

Fix bug 1290962: Include locale in Fx download scene2 URL