1290989 - Chunk m-gl on Desktop

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task, P1)

Description

[Kelsey Gilbert [:jgilbert]]

This should help with our intermittants.

I think we also have changes which are going to cause perma-oranges if we don't do this.

Comment 1

[Alin Selagea [:aselagea]]

@Jeff: any idea on how many chunks we want for these tests?

Comment 2

[Kelsey Gilbert [:jgilbert]]

(In reply to Alin Selagea [:aselagea][:buildduty] from comment #1)
> @Jeff: any idea on how many chunks we want for these tests?

Let's do three for now.

Comment 3

[Kelsey Gilbert [:jgilbert]]

We really want this sooner rather than later. I take it this isn't hard to do, but it does require knowing where to look. As much as I'd like to help write the patch, it would be much faster if someone familiar could just do it.

Comment 4

[Alin Selagea [:aselagea]]

Attachment: bug_1290989.patch

bb-configs changes

Comment 5

[Alin Selagea [:aselagea]]

Attachment: diff.txt

Tests diff.

[[e-mail] chunk_webgl]$ cat old | grep 'mochitest-gl' | wc -l
344
[[e-mail] chunk_webgl]$ cat new | grep 'mochitest-gl' | wc -l
1032

Comment 6

[Justin Wood (:Callek)]

...history has shown chunking can introduce new intermittents/perma-failures due to leaked test state from one test to another, and the latter test requires said state (by accident).

I'm less keen to modify this to chunk on branches that have already ridden up (like the m-r stuff here)

:jgilbert any thoughts as to that affect before kim reviews?

Comment 7

[Justin Wood (:Callek)]

Also this will need an in-tree patch for linux/android, if desired:

https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/desktop-test/tests.yml#291

https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/android-test/tests.yml#170

Some useful docs for that also exist at:

https://dxr.mozilla.org/mozilla-central/source/taskcluster/docs/how-tos.rst#59

Comment 8

[Kelsey Gilbert [:jgilbert]]

(In reply to Justin Wood (:Callek) from comment #6)
> ...history has shown chunking can introduce new intermittents/perma-failures
> due to leaked test state from one test to another, and the latter test
> requires said state (by accident).
> 
> I'm less keen to modify this to chunk on branches that have already ridden
> up (like the m-r stuff here)
> 
> :jgilbert any thoughts as to that affect before kim reviews?

We want this up to aurora so it can follow v50. We don't need all the branches though.

Comment 9

[Kim Moir [:kmoir] ET]

Comment on attachment 8780002 [details] [diff] [review]
bug_1290989.patch

Alin this patch needs to be modified so that it accounts for the remarks in comment 7 
We want this up to aurora so it can follow v50
(not all branches)
Also, it we need to have a patch to change the chunks for the linux desktop builds that run on taskclusters (link in comment 6)

Comment 10

[Kelsey Gilbert [:jgilbert]]

(In reply to Kim Moir [:kmoir] from comment #9)
> Comment on attachment 8780002 [details] [diff] [review]
> bug_1290989.patch
> 
> Alin this patch needs to be modified so that it accounts for the remarks in
> comment 7 
> We want this up to aurora so it can follow v50
> (not all branches)
> Also, it we need to have a patch to change the chunks for the linux desktop
> builds that run on taskclusters (link in comment 6)

Our high-priority need is just Windows, for now. Linux can be pushed back if it would take longer.

Comment 11

[Alin Selagea [:aselagea]]

Attachment: [bb-configs]bug_1290989.patch

Comment 12

[Alin Selagea [:aselagea]]

Attachment: [m-c]bug_1290989.patch

Specify the number of chunks in tests.yml

Comment 13

[Alin Selagea [:aselagea]]

Attachment: diff.txt

[[e-mail] chunk_webgl]$ cat old | grep 'mochitest-gl' | grep -E 'mozilla-release'\|'mozilla-beta'\|'mozilla-esr45'\|'mozilla-aurora' | wc -l
115
[[e-mail] chunk_webgl]$ cat new | grep 'mochitest-gl' | grep -E 'mozilla-release'\|'mozilla-beta'\|'mozilla-esr45'\|'mozilla-aurora' | wc -l
345

Comment 14

[Justin Wood (:Callek)]

Comment on attachment 8780583 [details] [diff] [review]
[bb-configs]bug_1290989.patch

Logic is flipped here -- we *don't* want to chunk on -release -esr45 etc, but *do* want to chunk on central (and I think aurora, .. whatever this bug said above).

Comment 15

[Alin Selagea [:aselagea]]

Attachment: [bb-configs]bug_1290989.patch

Sorry for the confusion. I updated the patch so that it chunks on all branches having gecko version >= 50.

Comment 16

[Alin Selagea [:aselagea]]

Attachment: diff.txt

New tests diff.

Comment 17

[Justin Wood (:Callek)]

Comment on attachment 8781493 [details] [diff] [review]
[bb-configs]bug_1290989.patch

...redirecting my stolen review back at kim.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f11bd297cbb3
Chunk m-gl on Desktop r=kmoir

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f11bd297cbb3