Closed
Bug 1291017
Opened 9 years ago
Closed 9 years ago
Home screen does not appear when switching between two home screen tabs
Categories
(Firefox for iOS :: Home screen, defect)
Tracking
()
VERIFIED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 5.1+ | --- |
People
(Reporter: nalcock, Assigned: nalcock)
Details
Attachments
(1 file)
Steps to reproduce:
1. Open two new tabs, to the home panel.
2. Restart the app.
3. Switch from the first tab to the second tab.
Expected result: The second tab will load as normal.
Actual result: The second tab will fail to load the home panel.
| Assignee | ||
Updated•9 years ago
|
Assignee: nobody → nalcock
| Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8776708 -
Flags: review?(bnicholson)
Updated•9 years ago
|
tracking-fxios:
--- → ?
Comment 2•9 years ago
|
||
Comment on attachment 8776708 [details] [review]
Pull request
Nice catch! I guess that's why the "finished" hack was there before, but it's definitely better to explicitly control the animation completion handler rather than guessing whether we want to call it based on the finished state.
Attachment #8776708 -
Flags: review?(bnicholson) → review+
| Assignee | ||
Comment 3•9 years ago
|
||
I believe this is actually also fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1289717, which has just been landed, so perhaps this patch isn't necessary after all?
Comment 4•9 years ago
|
||
Resolved with linked bug in comment 3.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 5•9 years ago
|
||
I'm unable to reproduce this issue on master 3f103883
Status: RESOLVED → VERIFIED
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•