Should pass const StyleAnimationValue& to CreateStyleContextForAnimationValue.

RESOLVED FIXED in Firefox 51

Status

()

Core
DOM: Animation
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: hiro, Assigned: ktakashi19980515)

Tracking

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
http://hg.mozilla.org/mozilla-central/file/ffac2798999c/dom/animation/KeyframeEffect.cpp#l1462
Priority: -- → P3
Assignee: nobody → ktakashi19980515
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8785554 [details]
Bug 1291061 - Pass const StyleAnimationValue& to CreateStyleContextForAnimationValue

https://reviewboard.mozilla.org/r/74730/#review72564

Looks good! Thank you!
Attachment #8785554 - Flags: review?(bbirtles) → review+
https://treeherder.mozilla.org/#/jobs?repo=try&revision=93eb013ed0dc

Comment 4

a year ago
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/88248d124b9a
Pass const StyleAnimationValue& to CreateStyleContextForAnimationValue r=birtles

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/88248d124b9a
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.