1291080 - Remove RTSP component from code base

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: RTSP, defect, P1)

Description

[Blake Wu [:bwu][:blakewu]]

Since we are refactoring media codes and find RTSP should not required so much due to B2G sunset, we are planning to remove RTSP to make our codes simpler.

Comment 1

[Blake Wu [:bwu][:blakewu]]

Ethan,
Do you have any concerns?

Comment 2

[Blake Wu [:bwu][:blakewu]]

If you don't have concerns, Benjamin is very happy to remove the codes. :-)

Comment 3

[Ethan Tseng [:ethan]]

(In reply to Blake Wu [:bwu][:blakewu] from comment #1)
> Ethan,
> Do you have any concerns?

Sad... all the works I did in the first year at Mozilla will be erased.  :(


Just kidding, I understand the extra complexity that RTSP brought in media element is not worthwhile to maintain since RTSP is rarely used (or even not used at all?)

My only question is that should we remove all RTSP codes or only remove its codes within media element (MediaDecoder, MediaResource, HTMLMediaElement, etc.)?
I assume we prefer to do the later to avoid dead code.

Comment 4

[Ethan Tseng [:ethan]]

By the way, are we still maintaining B2G build somewhere?
Do we need to make sure the code removal doesn't break B2G builds on any platform?

Comment 5

[[:fabrice] Fabrice Desré]

(In reply to Ethan Tseng [:ethan] from comment #4)
> By the way, are we still maintaining B2G build somewhere?
> Do we need to make sure the code removal doesn't break B2G builds on any
> platform?

That would be nice, but since b2g is Tier 3 nothing forces you to do that. The B2G OS community still does builds and unbreak things when something bad happens.

But I'm sure you still have a B2G/ tree somewhere right? ;)

Comment 6

[Ethan Tseng [:ethan]]

(In reply to [:fabrice] Fabrice Desré from comment #5)
> That would be nice, but since b2g is Tier 3 nothing forces you to do that.
> The B2G OS community still does builds and unbreak things when something bad
> happens.
> But I'm sure you still have a B2G/ tree somewhere right? ;)

Luckily yes! :)

Also we can see B2G builds are still healthy on Treeherder.
(B2G Device Image opt/debug)
I'll avoid breaking them.

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Ethan Tseng [:ethan] from comment #3)
> My only question is that should we remove all RTSP codes or only remove its
> codes within media element (MediaDecoder, MediaResource, HTMLMediaElement,
> etc.)?


Thanks Ethan.

I think we should start by removing the RTSP code in MediaDecoder, MediaResource, element, and reader, and then work backwards from there and remove anything that's no longer used. For example, can the code in netwerk/protocol/rtsp/ also go?

Comment 8

[Ethan Tseng [:ethan]]

(In reply to Chris Pearce (:cpearce) from comment #7)
> Thanks Ethan.
> I think we should start by removing the RTSP code in MediaDecoder,
> MediaResource, element, and reader, and then work backwards from there and
> remove anything that's no longer used. For example, can the code in
> netwerk/protocol/rtsp/ also go?

Hi Chris,
Yes, that's exactly what our plan is!
I am filing a bug right now. :)

Comment 9

[Ethan Tseng [:ethan]]

Bug 1291629 was filed in order to remove all RTSP codes from media components.

When it is done, I'll remove anything else about RTSP from our code base.
Most of them should be under netwerk/protocol/rtsp/.

Comment 10

[Ethan Tseng [:ethan]]

(In reply to Ethan Tseng [:ethan] from comment #6)
> (In reply to [:fabrice] Fabrice Desré from comment #5)
> > That would be nice, but since b2g is Tier 3 nothing forces you to do that.
> > The B2G OS community still does builds and unbreak things when something bad
> > happens.
> > But I'm sure you still have a B2G/ tree somewhere right? ;)
> 
> Also we can see B2G builds are still healthy on Treeherder.
> (B2G Device Image opt/debug)
> I'll avoid breaking them.

Hi Fabrice,

I updated to the latest code by repo sync, and tried many different builds, including flame-kk, aries-kk and emulator-l.  I even git clone the repository from scratch.
But none of them can be built successfully.
Then I checked Treeherder, it seems recent B2G builds all failed.
(/home/worker/workspace/gecko/dom/media/MediaData.cpp:353:34: error: 'aImage' was not declared in this scope)

Do you have idea on how to make a B2G build successfully right now?

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

bug 1292464?

Comment 12

[Ethan Tseng [:ethan]]

(In reply to JW Wang [:jwwang] from comment #11)
> bug 1292464?

Hey JW,
Thanks! Let me try it!

Comment 13

[:gerard-majax]

(In reply to Ethan Tseng [:ethan] from comment #12)
> (In reply to JW Wang [:jwwang] from comment #11)
> > bug 1292464?
> 
> Hey JW,
> Thanks! Let me try it!

Looks like my patch was incomplete, make sure you test with the last one I sent :)

Comment 14

[BMO Automation]

Firefox OS is not being worked on