Closed Bug 1291083 Opened 3 years ago Closed 3 years ago

Textures with depth-compare should be filterable

Categories

(Core :: Canvas: WebGL, defect)

50 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Summary: Textures with depth-compare are filterable → Textures with depth-compare should be filterable
This also makes depth-textures follow filtering rules, whereas before we
allowed filtered depth textures for WEBGL_depth_texture.

Review commit: https://reviewboard.mozilla.org/r/68452/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68452/
Attachment #8776796 - Flags: review?(mtseng)
At least one of the GL exts does include sample code that uses LINEAR filtering with the depth texture, and the conformance test for WEBGL_depth_texture also requires it. Let's allow it for now, though I'm a little hesitant about it.
Specifically, GLES3 specifies that depth formats without texture-compare enabled are *not* filterable. They are filterable when texture-compare is non-NONE though.
Comment on attachment 8776796 [details]
1291083 - Textures with depth-compare should be filterable. -

https://reviewboard.mozilla.org/r/68452/#review65872
Attachment #8776796 - Flags: review?(mtseng) → review+
Attachment #8776829 - Flags: review?(mtseng) → review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8aab2bd2e0b
Textures with depth-compare should be filterable. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/473613fb3479
Explicitly make WEBGL_depth_texture formats filterable. - r=mtseng
https://hg.mozilla.org/mozilla-central/rev/c8aab2bd2e0b
https://hg.mozilla.org/mozilla-central/rev/473613fb3479
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.