Textures with depth-compare should be filterable

RESOLVED FIXED in Firefox 51

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

(Blocks: 1 bug)

50 Branch
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Updated

2 years ago
Summary: Textures with depth-compare are filterable → Textures with depth-compare should be filterable
(Assignee)

Comment 1

2 years ago
Created attachment 8776796 [details]
1291083 - Textures with depth-compare should be filterable. -

This also makes depth-textures follow filtering rules, whereas before we
allowed filtered depth textures for WEBGL_depth_texture.

Review commit: https://reviewboard.mozilla.org/r/68452/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68452/
Attachment #8776796 - Flags: review?(mtseng)
(Assignee)

Comment 2

2 years ago
Created attachment 8776829 [details]
Bug 1291083 - Explicitly make WEBGL_depth_texture formats filterable. -

Review commit: https://reviewboard.mozilla.org/r/68498/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68498/
Attachment #8776829 - Flags: review?(mtseng)
(Assignee)

Comment 3

2 years ago
At least one of the GL exts does include sample code that uses LINEAR filtering with the depth texture, and the conformance test for WEBGL_depth_texture also requires it. Let's allow it for now, though I'm a little hesitant about it.
(Assignee)

Comment 4

2 years ago
Specifically, GLES3 specifies that depth formats without texture-compare enabled are *not* filterable. They are filterable when texture-compare is non-NONE though.
Comment on attachment 8776796 [details]
1291083 - Textures with depth-compare should be filterable. -

https://reviewboard.mozilla.org/r/68452/#review65872
Attachment #8776796 - Flags: review?(mtseng) → review+
Attachment #8776829 - Flags: review?(mtseng) → review+

Comment 7

2 years ago
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8aab2bd2e0b
Textures with depth-compare should be filterable. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/473613fb3479
Explicitly make WEBGL_depth_texture formats filterable. - r=mtseng
(Assignee)

Updated

2 years ago
Blocks: 1291386

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c8aab2bd2e0b
https://hg.mozilla.org/mozilla-central/rev/473613fb3479
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.