1291178 - [Presentation WebAPI] Rename connect/disconnect functions in PresentationControlService

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect, P3)

Description

[Kershaw Chang [:kershaw]]

Please see bug 1197690 comment #11.

Comment 1

[svensevenslow]

Attachment: Renaming disconnect/reconnect/terminate/launch functions in PresentationControlService

Comment 2

[svensevenslow]

Does the review+ means that the patch is ok? Is there anything else I need to do?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

I just pushed it to try for you. Assuming it's fine, we can land it :)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbcc10e0e38d4c86839b0a7f624ee7cd235bb088

Comment 4

[Emilio Cobos Álvarez (:emilio)]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #3)
> I just pushed it to try for you. Assuming it's fine, we can land it :)
> 
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=fbcc10e0e38d4c86839b0a7f624ee7cd235bb088

There are a couple tests failing which look related, like:

  dom/presentation/tests/mochitest/test_presentation_sender_startWithDevice.html
  dom/presentation/tests/mochitest/test_presentation_tcp_sender.html
  dom/presentation/tests/xpcshell/test_tcp_control_channel.js

So still needs some work.

Comment 5

[Videet Singhai]

hello, I would like to work on this. Can anyone please guide?

Comment 6

[danielvictoriadbugzilla]

Attachment: Bug 1291178 - Renamed disconnect/reconnect/terminate/launch functions in PresentationControlService to reflect which referred to the channel and which to presentation

Comment 7

[danielvictoriadbugzilla]

Hello, I would like to work on this bug, I have submitted a patch through phabricator which uses the previous one submitted and fixes the tests.

Comment 8

[Sonia Singla :soniasingla]

Is this bug still valid? If yes, can i work on this? :)

Comment 9

[Kohei Yoshino [:kohei]]

I don’t know.

Comment 10

[Kagami Rosylight [:saschanaz] (they/them)]

Bug 1697680 removed Presentation API implementation.