Closed Bug 1291199 Opened 8 years ago Closed 8 years ago

Intermittent toolkit/components/extensions/test/xpcshell/test_ext_native_messaging.js | xpcshell return code: 0

Categories

(WebExtensions :: Untriaged, defect)

defect
Not set
normal

Tracking

(firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: kmag)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

I was hoping this wouldn't be an issue, but it's not unexpected. I think we'll just need to retry a few times before we consider it a failure.
Comment on attachment 8777198 [details]
Bug 1291199: Retry subprocess perf tests on failure.

https://reviewboard.mozilla.org/r/68802/#review66180

Looks good to me.  I wouldn't object to having the loop directly in the background script in the native messaging test instead of unloading and reloading the extension, but its not a deal breaker this way..
Attachment #8777198 - Flags: review?(aswan) → review+
https://reviewboard.mozilla.org/r/68802/#review66180

Yeah, that probably makes sense.
https://hg.mozilla.org/mozilla-central/rev/79b31ab92faa
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee: nobody → kmaglione+bmo
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: