Closed
Bug 1291201
Opened 8 years ago
Closed 7 years ago
Add an alert_email for the SECURITY_UI histogram
Categories
(Firefox :: Security, defect, P5)
Firefox
Security
Tracking
()
RESOLVED
FIXED
Firefox 54
People
(Reporter: past, Assigned: francois)
Details
(Keywords: good-first-bug)
Attachments
(2 files)
The kitchen sink that is SECURITY_UI needs an email address for the alert_email field. Tanvi and François suggested that seceng-telemetry@mozilla.com would be appropriate in this case. Adding a reference in the description field to the information contained in nsISecurityUITelemetry.idl would be good too. https://dxr.mozilla.org/mozilla-central/rev/ffac2798999c5b84f1b4605a1280994bb665a406/toolkit/components/telemetry/Histograms.json#5327
Updated•8 years ago
|
Priority: -- → P5
Comment 1•8 years ago
|
||
Attachment #8779478 -
Flags: review?(francois)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → tanvi
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Panos, your team is also interested in some of the probes in SECURITY_UI. Maybe we should add fxprivacy@mozilla.com too?
Flags: needinfo?(past)
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8779478 [details] [diff] [review] Bug1291201.patch Review of attachment 8779478 [details] [diff] [review]: ----------------------------------------------------------------- You should also remove SECURITY_UI from the "alert_emails" whitelist: http://searchfox.org/mozilla-central/rev/d83f1528dbcb1e837d99cf5b6c36a90b03bf0e77/toolkit/components/telemetry/histogram-whitelists.json#822
Attachment #8779478 -
Flags: review?(francois) → review-
Reporter | ||
Comment 4•8 years ago
|
||
I'm fine with adding fxprivacyandsecurity@mozilla.com to the list of addresses.
Flags: needinfo?(past)
Assignee | ||
Comment 5•7 years ago
|
||
Stealing this from Tanvi, I'm pretty sure she won't mind.
Assignee: tanvi → francois
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8833218 [details] Bug 1291201 - Add email alerts, bug number and improve description of SECURITY_UI. https://reviewboard.mozilla.org/r/109450/#review110592
Attachment #8833218 -
Flags: review?(benjamin) → review+
Pushed by fmarier@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/708870a6aeff Add email alerts, bug number and improve description of SECURITY_UI. r=bsmedberg
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/708870a6aeff
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment 11•7 years ago
|
||
Should this be uplifted to 53?
Assignee | ||
Comment 12•7 years ago
|
||
It doesn't seem important enough to warrant an uplift to beta.
Flags: needinfo?(francois)
Comment 13•7 years ago
|
||
Thanks François, updating status flags.
Comment 14•7 years ago
|
||
Browser:Firefox Aurora 54 OS:Windows 10 X64 Required some additional details for the given bug. Status:Verified and not fixed [bugday-20170419]
You need to log in
before you can comment on or make changes to this bug.
Description
•