Closed Bug 1291229 Opened 4 years ago Closed 4 years ago

Fix typo for moving Java bindings to mozilla::java namespace

Categories

(Core :: Widget: Android, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: JamesCheng, Assigned: JamesCheng)

Details

Attachments

(1 file)

Hi Jim,

Please help for reviewing this patch.

Thank you very much.
Comment on attachment 8776892 [details]
Bug 1291229 - Fix typo for moving Java bindings to mozilla::java namespace.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68546/diff/1-2/
Attachment #8776892 - Flags: review?(nchen)
Comment on attachment 8776892 [details]
Bug 1291229 - Fix typo for moving Java bindings to mozilla::java namespace.

https://reviewboard.mozilla.org/r/68546/#review66040

Thanks!
Attachment #8776892 - Flags: review?(nchen) → review+
Priority: -- → P3
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fcb956172cd
Fix typo for moving Java bindings to mozilla::java namespace. r=jchen
Keywords: checkin-needed
I am not familiar with the try build procedure. I think it will do a clobber build...

Hi Jim, 

Could you please tell me how do I deal with this ?

Should I modify the CLOBBER file instead?

Thank you!
Flags: needinfo?(jacheng) → needinfo?(nchen)
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ee6f2eb8b34
Fix typo for moving Java bindings to mozilla::java namespace. r=jchen
Your patch needed to update the generated files that are part of the tree. I did that and checked in again for you.
Flags: needinfo?(nchen)
Oh, I see.

Thank you, Jim!
https://hg.mozilla.org/mozilla-central/rev/8ee6f2eb8b34
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.