1291229 - Fix typo for moving Java bindings to mozilla::java namespace

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect, P3)

Description

[James Cheng[:JamesCheng]]

Generate the correct namespace name

[1] https://dxr.mozilla.org/mozilla-central/rev/ffac2798999c5b84f1b4605a1280994bb665a406/build/annotationProcessors/SDKProcessor.java#114
[2] https://dxr.mozilla.org/mozilla-central/rev/ffac2798999c5b84f1b4605a1280994bb665a406/build/annotationProcessors/AnnotationProcessor.java#87

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1291229 - Fix typo for moving Java bindings to mozilla::java namespace.

Review commit: https://reviewboard.mozilla.org/r/68546/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68546/

Comment 2

[James Cheng[:JamesCheng]]

Hi Jim,

Please help for reviewing this patch.

Thank you very much.

Comment 3

[James Cheng[:JamesCheng]]

Comment on attachment 8776892 [details]
Bug 1291229 - Fix typo for moving Java bindings to mozilla::java namespace.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68546/diff/1-2/

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8776892 [details]
Bug 1291229 - Fix typo for moving Java bindings to mozilla::java namespace.

https://reviewboard.mozilla.org/r/68546/#review66040

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fcb956172cd
Fix typo for moving Java bindings to mozilla::java namespace. r=jchen

Comment 6

[Nathan Froyd [:froydnj]]

Backed out for Android build bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=33312050&repo=mozilla-inbound#L21224

https://hg.mozilla.org/integration/mozilla-inbound/rev/148015158424d5d53446fbbf22438fb12da4c6f3

Comment 7

[James Cheng[:JamesCheng]]

I am not familiar with the try build procedure. I think it will do a clobber build...

Hi Jim, 

Could you please tell me how do I deal with this ?

Should I modify the CLOBBER file instead?

Thank you!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ee6f2eb8b34
Fix typo for moving Java bindings to mozilla::java namespace. r=jchen

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Your patch needed to update the generated files that are part of the tree. I did that and checked in again for you.

Comment 10

[James Cheng[:JamesCheng]]

Oh, I see.

Thank you, Jim!

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8ee6f2eb8b34