Closed Bug 1291268 Opened 8 years ago Closed 8 years ago

HiDPI image are missing from video controls on Windows and Linux

Categories

(Toolkit :: Video/Audio Controls, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: jaws, Assigned: jaws)

Details

Attachments

(1 file)

      No description provided.
Attachment #8776935 - Flags: review?(ralin) → review+
Comment on attachment 8776935 [details]
Bug 1291268 - HiDPI image are missing from video controls on Windows and Linux.

https://reviewboard.mozilla.org/r/68564/#review65902

Looks great! It's nice you eliminate duplicate code and resources :)

Thanks
https://hg.mozilla.org/integration/fx-team/rev/b965a94cd13ecf249b4bc4106c32b99ba420f243
Bug 1291268 - HiDPI image are missing from video controls on Windows and Linux. r=ralin
https://hg.mozilla.org/mozilla-central/rev/b965a94cd13e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Comment on attachment 8776935 [details]
Bug 1291268 - HiDPI image are missing from video controls on Windows and Linux.

Approval Request Comment
[Feature/regressing bug #]: hidpi images for video controls
[User impact if declined]: blurry button in video controls on windows and linux
[Describe test coverage new/current, TreeHerder]: none, CSS change only
[Risks and why]: low risk, using CSS already shipping on OSX
[String/UUID change made/needed]: none
Attachment #8776935 - Flags: approval-mozilla-aurora?
Whiteboard: [uplift note: this patch must be applied after the patch from bug 1291009]
Hi Jared, this is a pretty big change (# of files) for an Aurora uplift. Did we plan for this work to land in Nightly 50 but it missed the merge date? I am just wondering if this is something that can ride the 51 train or not. Please let me know.
Flags: needinfo?(jaws)
This was not planned for 50 but is just a nice to have. We do however need to have bug 1291009 uplifted. The large number of files is only due to the fact that all of the images were moved to a central and shared location instead of having duplicates.
Flags: needinfo?(jaws)
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #7)
> This was not planned for 50 but is just a nice to have. We do however need
> to have bug 1291009 uplifted. The large number of files is only due to the
> fact that all of the images were moved to a central and shared location
> instead of having duplicates.

I understand. Thanks! As such the change looks too big but given the low risk, I think I am ok with uplifting to Aurora50.
Comment on attachment 8776935 [details]
Bug 1291268 - HiDPI image are missing from video controls on Windows and Linux.

HiDPI images provide a better user experience, low risk CSS-only change, Aurora50+
Attachment #8776935 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/22bc0a87c504
Whiteboard: [uplift note: this patch must be applied after the patch from bug 1291009]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: