Closed Bug 1291272 Opened 4 years ago Closed 4 years ago

Fix test devtools/client/aboutdebugging/test/browser_addons_reload.js which fails in beta where extension signing is required

Categories

(DevTools :: about:debugging, defect, P2)

defect

Tracking

(firefox49 fixed, firefox50 fixed, firefox51 fixed)

RESOLVED FIXED
Firefox 51
Tracking Status
firefox49 --- fixed
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: jsnajdr, Assigned: kumar)

References

Details

Attachments

(1 file)

In bug 1291236 we disabled the test, now let's fix it and reenable. Probably by getting the file devtools/client/aboutdebugging/test/addons/bug1273184.xpi signed?
Blocks: 1291236
Thanks for filing this bug Jarda!

Kumar, could you please have a quick look at this test?
Flags: needinfo?(kumar.mcmillan)
Priority: -- → P2
Andrew, it looks like maybe you signed some fixture add-ons for similar test failures? What account are we using to sign those?
Flags: needinfo?(kumar.mcmillan) → needinfo?(aswan)
Here is the info about how to sign add-ons in the test suite: https://wiki.mozilla.org/EngineeringProductivity/HowTo/SignExtensions
(In reply to Kumar McMillan [:kumar] (needinfo all the things) from comment #2)
> Andrew, it looks like maybe you signed some fixture add-ons for similar test
> failures? What account are we using to sign those?

Discussed over IRC, the link from comment 3 is the essential one.
Flags: needinfo?(aswan)
Assignee: nobody → kumar.mcmillan
Comment on attachment 8777001 [details]
Bug 1291272 - Fix aboutdebugging reload test that requires a signed add-on.  a=test-only

Alex, could you please have a look at Kumar's patch?
Attachment #8777001 - Flags: review?(janx) → review?(poirot.alex)
Comment on attachment 8777001 [details]
Bug 1291272 - Fix aboutdebugging reload test that requires a signed add-on.  a=test-only

https://reviewboard.mozilla.org/r/68610/#review65888
Attachment #8777001 - Flags: review?(poirot.alex) → review+
Here's a try build that looks pretty good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c76deb0d7ae3

I don't know if this try build replicated the original test env but I was able to force a failure locally before my fix by setting MOZ_REQUIRE_SIGNING=1
Comment on attachment 8777001 [details]
Bug 1291272 - Fix aboutdebugging reload test that requires a signed add-on.  a=test-only

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68610/diff/1-2/
Attachment #8777001 - Attachment description: Bug 1291272 - Fix aboutdebugging reload test that requires a signed add-on. → Bug 1291272 - Fix aboutdebugging reload test that requires a signed add-on. a=test-only
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/e4ba059c2a80
Fix aboutdebugging reload test that requires a signed add-on. r=ochameau a=test-only
Keywords: checkin-needed
Comment on attachment 8777001 [details]
Bug 1291272 - Fix aboutdebugging reload test that requires a signed add-on.  a=test-only

Approval Request Comment
[Feature/regressing bug #]: This test was failing on beta builds only: https://bugzilla.mozilla.org/show_bug.cgi?id=1291236
[User impact if declined]: N/A
[Describe test coverage new/current, TreeHerder]: A single add-on used by this test was signed by AMO
[Risks and why]: if not fixed, this will continue to fail in beta and release builds
[String/UUID change made/needed]:
Attachment #8777001 - Flags: approval-mozilla-beta?
Attachment #8777001 - Flags: approval-mozilla-aurora?
(I asked for aurora approval, because otherwise the test will fail once 49 gets merged to beta.
Comment on attachment 8777001 [details]
Bug 1291272 - Fix aboutdebugging reload test that requires a signed add-on.  a=test-only

Hello Tim, Kummar, Test only checkins do not need relman review.
Flags: needinfo?(ntim.bugs)
Flags: needinfo?(kumar.mcmillan)
Attachment #8777001 - Flags: approval-mozilla-beta?
Attachment #8777001 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/releases/mozilla-aurora/rev/f2990ddc86ae
Flags: needinfo?(ntim.bugs)
Flags: needinfo?(kumar.mcmillan)
https://hg.mozilla.org/mozilla-central/rev/e4ba059c2a80
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.