1291303 - Import latest Readability.js

Status: RESOLVED FIXED

(Firefox for iOS :: Reader View, defect, P3)

Comment 1

[Bryan Munar (:bkmunar)]

Attachment: PR

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8786445 [details] [review]
PR

Er, I don't understand this commit. You aren't replacing Readability.js anywhere; you're just dropping in a new file. Where is this getting used?

Comment 3

[Bryan Munar (:bkmunar)]

We import Readability in the Cartfile

Comment 4

[Brian Nicholson (:bnicholson)]

To clarify: we pull in Readability via Carthage, and its version is pinned to "master" (as opposed to an older commit). So unless I'm mistaken, we just need to make sure we've pulled in the latest HEAD before doing a build.

Comment 5

[Brian Nicholson (:bnicholson)]

Oops, I forgot that bootstrapped dependencies are tied to Cartfile.resolved, not Cartfile. So there is something actionable in the bug: `carthage update` Readability so that it points to a more recent commit in Cartfile.resolved.

Sorry for the bug churn!

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8786445 [details] [review]
PR

Can we see whether this fixes bug 1187381 now?