Closed Bug 1291331 Opened 4 years ago Closed 3 years ago

Windows 10 start menu tile doesn't always use updated settings in firefox.VisualElementsManifest.xml

Categories

(Firefox :: Installer, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 57
Iteration:
57.1 - Aug 15
Tracking Status
firefox51 --- affected
firefox57 --- fixed

People

(Reporter: jaws, Assigned: mhowell)

References

Details

(Whiteboard: [reserve-photon-animation])

Attachments

(1 file)

Summary: The installer needs to update the lastWriteTime of the Firefox startmenu shortcut for all users and the current user → Windows 10 start menu tile doesn't always use updated settings in firefox.VisualElementsManifest.xml. Fix is likely in comment #0
I guess we need to do something with auto-upgrade as well.
[Tracking Requested - why for this release]: in changing the Firefox icon, we should make sure that the updater clears the Windows Start Menu icon cache so the new icons will be used.
Whiteboard: [photon-animation] [triage]
I've just done some testing and it seems like the approach from bug 1284517 did not work; as in, the method it uses to update the last modified time does not actually affect the last modified time. We might be better off calling the SetFileTime API to update the time directly, or failing that we can just recreate the shortcut file.

Note that this does not make bug 1284517 comment 16 incorrect; we do still need to be doing this in both start menu locations.
SetFileTime appears to be working, I'll put up a patch that uses that.
Assignee: nobody → mhowell
Status: NEW → ASSIGNED
Priority: -- → P1
Summary: Windows 10 start menu tile doesn't always use updated settings in firefox.VisualElementsManifest.xml. Fix is likely in comment #0 → Windows 10 start menu tile doesn't always use updated settings in firefox.VisualElementsManifest.xml
Attached patch PatchSplinter Review
Attachment #8894644 - Flags: review?(robert.strong.bugs)
Attachment #8894644 - Flags: review?(robert.strong.bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e68e6723cff722c5e948ff8851bc589bda6a3be0
Bug 1291331 - Update last modified time on start menu shortcuts during install or update. r=rstrong
Flags: qe-verify?
Whiteboard: [photon-animation] [triage] → [reserve-photon-animation]
https://hg.mozilla.org/mozilla-central/rev/e68e6723cff7
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Iteration: --- → 57.1 - Aug 15
Duplicate of this bug: 1388126
Duplicate of this bug: 1297898
Since this is fixed, no need to track it for 57.
Flags: qe-verify? → qe-verify-
Depends on: 1391910
Duplicate of this bug: 1378142
Duplicate of this bug: 1435167
You need to log in before you can comment on or make changes to this bug.