1291334 - Fix a few issues in w3c-submitted flexbox reftests

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

Filing this bug to fix some minor issues in our w3c-submitted flexbox reftests, reported by biesi over email.

(1)

https://github.com/w3c/csswg-test/blob/master/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-basic-textarea-horiz-001.xhtml

https://github.com/w3c/csswg-test/blob/master/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-basic-textarea-horiz-001-ref.xhtml

The question is about the second flexbox in this test. In the reference, that div has a height: 24px specified. But in the test itself, the flexbox has no explicit height and the textarea has a height: 20px plus a 1px border, adding to 22px. 

Apparently Firefox has a 1px block-start and block-end margin for textareas:
https://dxr.mozilla.org/mozilla-central/source/layout/style/res/forms.css#125

Would you be open to modifying that test to not rely on that? Either specify margin: 1px 0; or margin: 0;.

(2)
https://github.com/w3c/csswg-test/blob/master/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-whitespace-handling-001a.xhtml
and
https://github.com/w3c/csswg-test/blob/master/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-whitespace-handling-001b.xhtml

reference solidblue.png, even though it actually exists as support/solidblue.png. I

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1291334 part 1: Explicitly set margin on textareas within reftest flexbox-basic-textarea-horiz-001.xhtml, to remove assumptions about default styling. (no review)

Review commit: https://reviewboard.mozilla.org/r/69110/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69110/

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1291334 part 2: Fix path to solidblue.png image in flexbox-whitespace-handling-001* reftest files. (no review)

Review commit: https://reviewboard.mozilla.org/r/69112/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69112/

Comment 3

[Daniel Holbert [:dholbert]]

Patches up -- I triggered a try run:
 https://treeherder.mozilla.org/#/jobs?repo=try&revision=a993488772b6
...just in case the textarea margin change trips over some weird platform-specific widget rendering difference.  I'll land if the Try run goes well.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3534790e9a67
part 1: Explicitly set margin on textareas within reftest flexbox-basic-textarea-horiz-001.xhtml, to remove assumptions about default styling. (no review)
https://hg.mozilla.org/integration/mozilla-inbound/rev/607ba3f1f6a1
part 2: Fix path to solidblue.png image in flexbox-whitespace-handling-001* reftest files. (no review)

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3534790e9a67
https://hg.mozilla.org/mozilla-central/rev/607ba3f1f6a1

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Thanks! How often do you push these to https://github.com/w3c/csswg-test/tree/master/vendor-imports/mozilla/mozilla-central-reftests/flexbox?

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Normally I have a script that emails me each day if porting is needed.  But I can do it anytime, really...

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.csswg.org/test/rev/4ddc1e331fac

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Thanks!