Closed
Bug 1291347
Opened 8 years ago
Closed 8 years ago
Make CacheFileContextEvictor::EvictEntries shutdown aware
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: mayhemer, Assigned: michal)
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
1.12 KB,
patch
|
mayhemer
:
review+
|
Details | Diff | Splinter Review |
We can continue evicting long after shutdown. I see two options: - annotate the hang monitor we do something expected (not preferred) - just break the loop, since (AFAIK) we still keep the 'eviction file' telling us what should be deleted (that part needs to be confirmed) and restart on next session If the presumption is correct, this should be fairly easy to fix. Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1268569#c21
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8777841 -
Flags: review?(honzab.moz)
Reporter | ||
Comment 2•8 years ago
|
||
Comment on attachment 8777841 [details] [diff] [review] patch v1 Review of attachment 8777841 [details] [diff] [review]: ----------------------------------------------------------------- thanks.
Attachment #8777841 -
Flags: review?(honzab.moz) → review+
Pushed by mnovotny@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/000b263bb383 Make CacheFileContextEvictor::EvictEntries shutdown aware, r=honzab
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/000b263bb383
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•