Closed
Bug 1291365
Opened 5 years ago
Closed 5 years ago
Install run-task and hg robustcheckout on desktop-test image
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gps, Assigned: gps)
References
(Blocks 2 open bugs)
Details
Attachments
(10 files)
|
58 bytes,
text/x-review-board-request
|
dustin
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
dustin
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
dustin
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
dustin
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
dustin
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
dustin
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
dustin
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
dustin
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
dustin
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
dustin
:
review+
|
Details |
Let's get run-task and `hg robustcheckout` installed on the desktop-test Docker image.
|
Assignee | |
Comment 1•5 years ago
|
||
Currently, install-mercurial.sh only supports Ubuntu 16.04. In preparation for supporting other distros, we add code for performing OS/distro detection. Review commit: https://reviewboard.mozilla.org/r/69624/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69624/
Attachment #8778318 -
Flags: review?(dustin)
Attachment #8778319 -
Flags: review?(dustin)
Attachment #8778320 -
Flags: review?(dustin)
Attachment #8778321 -
Flags: review?(dustin)
|
|
Assignee | |
Comment 2•5 years ago
|
||
I produced Mercurial .deb packages for Ubuntu 12.04 and uploaded them to tooltool. I have updated the Mercurial installation script to detect Ubuntu 12.04 and install the appropriate Mercurial packages. Review commit: https://reviewboard.mozilla.org/r/69626/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69626/
|
|
Assignee | |
Comment 3•5 years ago
|
||
More determinism. More security. More reliable. Vendoring. Review commit: https://reviewboard.mozilla.org/r/69628/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69628/
|
|
Assignee | |
Comment 4•5 years ago
|
||
This also bumps the Mercurial version from 3.7.3 to 3.8.4. Review commit: https://reviewboard.mozilla.org/r/69630/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69630/
|
|
Assignee | |
Comment 5•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/69638/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69638/
Attachment #8778334 -
Flags: review?(dustin)
Attachment #8778335 -
Flags: review?(dustin)
Attachment #8778336 -
Flags: review?(dustin)
Attachment #8778337 -
Flags: review?(dustin)
Attachment #8778338 -
Flags: review?(dustin)
|
|
Assignee | |
Comment 6•5 years ago
|
||
Without this, we'll use the latest Ubuntu release at image build time! Review commit: https://reviewboard.mozilla.org/r/69640/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69640/
|
|
Assignee | |
Comment 7•5 years ago
|
||
And make it deterministic since we are using a vendored file. Review commit: https://reviewboard.mozilla.org/r/69642/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69642/
|
|
Assignee | |
Comment 8•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/69644/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69644/
|
|
Assignee | |
Comment 9•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/69646/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69646/
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 20•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8778318 [details] Bug 1291365 - Refactor install-mercurial.sh to detect OS version; https://reviewboard.mozilla.org/r/69624/#review67252
Attachment #8778318 -
Flags: review?(dustin) → review+
|
|
||
Comment 21•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8778319 [details] Bug 1291365 - Support installing Mercurial on Ubuntu 12.04; https://reviewboard.mozilla.org/r/69626/#review67254
Attachment #8778319 -
Flags: review?(dustin) → review+
|
|
||
Comment 22•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8778320 [details] Bug 1291365 - Install tooltool securely in ubuntu1204-test image; https://reviewboard.mozilla.org/r/69628/#review67256 ::: testing/docker/ubuntu1204-test/Dockerfile:8 (Diff revision 2) > > RUN useradd -d /home/worker -s /bin/bash -m worker > WORKDIR /home/worker > > +# %include testing/docker/recipes/tooltool.py > +ADD topsrcdir/testing/docker/recipes/tooltool.py /tmp/tooltool.py I fear someone is going to notice "Hey, tooltool's installed in `/tmp` so let's just use that!". Could this end up under `/setup` so it gets removed at the end of `system-setup.sh`? It's a minor issue, so feel free to not change this.
Attachment #8778320 -
Flags: review?(dustin) → review+
|
|
||
Comment 23•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8778321 [details] Bug 1291365 - Install Mercurial via install-mercurial.sh in ubuntu1204-test image; https://reviewboard.mozilla.org/r/69630/#review67258
Attachment #8778321 -
Flags: review?(dustin) → review+
|
|
||
Comment 24•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8778334 [details] Bug 1291365 - Add run-task to ubuntu1204-test image; https://reviewboard.mozilla.org/r/69638/#review67260
Attachment #8778334 -
Flags: review?(dustin) → review+
|
|
||
Comment 25•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8778335 [details] Bug 1291365 - Specify Ubuntu version in ubuntu1604-test image; https://reviewboard.mozilla.org/r/69640/#review67262
Attachment #8778335 -
Flags: review?(dustin) → review+
|
|
||
Comment 26•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8778336 [details] Bug 1291365 - Install tooltool securely in ubuntu1604-test image; https://reviewboard.mozilla.org/r/69642/#review67264
Attachment #8778336 -
Flags: review?(dustin) → review+
|
|
||
Comment 27•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8778337 [details] Bug 1291365 - Use install-mercurial.sh in ubuntu1604-test; https://reviewboard.mozilla.org/r/69644/#review67266
Attachment #8778337 -
Flags: review?(dustin) → review+
|
|
||
Comment 28•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8778338 [details] Bug 1291365 - Add run-task to ubuntu1604-test image; https://reviewboard.mozilla.org/r/69646/#review67268
Attachment #8778338 -
Flags: review?(dustin) → review+
|
|
||
Comment 29•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8778968 [details] Bug 1291365 - Remove hgrc file from desktop1604-test image; https://reviewboard.mozilla.org/r/70046/#review67270
Attachment #8778968 -
Flags: review?(dustin) → review+
|
|
Assignee | |
Comment 30•5 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8778320 [details] Bug 1291365 - Install tooltool securely in ubuntu1204-test image; https://reviewboard.mozilla.org/r/69628/#review67256 > I fear someone is going to notice "Hey, tooltool's installed in `/tmp` so let's just use that!". Could this end up under `/setup` so it gets removed at the end of `system-setup.sh`? It's a minor issue, so feel free to not change this. Makes sense. Will fix.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 41•5 years ago
|
||
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/62bd3cf6661d Refactor install-mercurial.sh to detect OS version; r=dustin https://hg.mozilla.org/integration/autoland/rev/df3c13ea7d3e Support installing Mercurial on Ubuntu 12.04; r=dustin https://hg.mozilla.org/integration/autoland/rev/dba9f54f0512 Install tooltool securely in ubuntu1204-test image; r=dustin https://hg.mozilla.org/integration/autoland/rev/51ac9d25dbe9 Install Mercurial via install-mercurial.sh in ubuntu1204-test image; r=dustin https://hg.mozilla.org/integration/autoland/rev/dca57fa9b9e2 Add run-task to ubuntu1204-test image; r=dustin https://hg.mozilla.org/integration/autoland/rev/fe0fc504b4b4 Specify Ubuntu version in ubuntu1604-test image; r=dustin https://hg.mozilla.org/integration/autoland/rev/5111fd8cb91d Install tooltool securely in ubuntu1604-test image; r=dustin https://hg.mozilla.org/integration/autoland/rev/3cf365cf9b90 Use install-mercurial.sh in ubuntu1604-test; r=dustin https://hg.mozilla.org/integration/autoland/rev/fdc5c16b3f8e Add run-task to ubuntu1604-test image; r=dustin https://hg.mozilla.org/integration/autoland/rev/470f72a4827c Remove hgrc file from desktop1604-test image; r=dustin
|
||
Comment 42•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/62bd3cf6661d https://hg.mozilla.org/mozilla-central/rev/df3c13ea7d3e https://hg.mozilla.org/mozilla-central/rev/dba9f54f0512 https://hg.mozilla.org/mozilla-central/rev/51ac9d25dbe9 https://hg.mozilla.org/mozilla-central/rev/dca57fa9b9e2 https://hg.mozilla.org/mozilla-central/rev/fe0fc504b4b4 https://hg.mozilla.org/mozilla-central/rev/5111fd8cb91d https://hg.mozilla.org/mozilla-central/rev/3cf365cf9b90 https://hg.mozilla.org/mozilla-central/rev/fdc5c16b3f8e https://hg.mozilla.org/mozilla-central/rev/470f72a4827c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•