Move uses of getExtensionUUID to UUIDMap

RESOLVED FIXED in Firefox 58

Status

defect
P5
normal
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: aswan, Assigned: mixedpuppy)

Tracking

(Blocks 1 bug)

unspecified
mozilla58
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox58 fixed)

Details

(Whiteboard: triaged)

Attachments

(1 attachment)

Reporter

Description

3 years ago
In bug 1213990, the function getExtensionUUID() defined in Extensions.jsm is converted to UUIDMap but there are a few references to getExtensionUUID in the tree, these should be converted to reference UUIDMap so that getExtensionUUID can be retired:

One is in a devtools test:
https://dxr.mozilla.org/mozilla-central/source/devtools/client/debugger/test/mochitest/browser_dbg_sources-webext-contentscript.js#35

And one is in test pilot:
https://github.com/mozilla/testpilot/blob/master/addon/lib/webextension-channels.js#L39

Updated

3 years ago
Priority: -- → P5
Whiteboard: triaged
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Assignee: nobody → mixedpuppy
Reporter

Comment 3

2 years ago
mozreview-review
Comment on attachment 8919536 [details]
Bug 1291399 remove references to getExtensionUUID,

https://reviewboard.mozilla.org/r/190382/#review195926

This looks fine to me but shouldn't we wait until the related test pilot issue is closed to actually land this?
Attachment #8919536 - Flags: review?(aswan) → review+
Assignee

Comment 4

2 years ago
Wil, can you help move ahead the testpilot github issue in comment 1?  I'm not certain who to contact for it.
Flags: needinfo?(wclouser)
Looks like Les is working on it in the issue.  We're on two week sprints so the earliest this would be out is halloween.
Flags: needinfo?(wclouser)
(Also, thanks for giving us a heads up and filing the issue!)
Assignee

Comment 7

2 years ago
Test pilot will update this week, we can land this next week.

Comment 8

2 years ago
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6be7ac2dffd2
remove references to getExtensionUUID, r=aswan

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6be7ac2dffd2
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58

Comment 10

2 years ago
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(mixedpuppy)
Assignee

Updated

2 years ago
Flags: needinfo?(mixedpuppy) → qe-verify-

Updated

Last year
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.