59 bytes, text/x-review-board-request
In bug 1213990, the function getExtensionUUID() defined in Extensions.jsm is converted to UUIDMap but there are a few references to getExtensionUUID in the tree, these should be converted to reference UUIDMap so that getExtensionUUID can be retired: One is in a devtools test: https://dxr.mozilla.org/mozilla-central/source/devtools/client/debugger/test/mochitest/browser_dbg_sources-webext-contentscript.js#35 And one is in test pilot: https://github.com/mozilla/testpilot/blob/master/addon/lib/webextension-channels.js#L39
Test pilot issue submitted. https://github.com/mozilla/testpilot/issues/2968
Comment on attachment 8919536 [details] Bug 1291399 remove references to getExtensionUUID, https://reviewboard.mozilla.org/r/190382/#review195926 This looks fine to me but shouldn't we wait until the related test pilot issue is closed to actually land this?
Attachment #8919536 - Flags: review?(aswan) → review+
Wil, can you help move ahead the testpilot github issue in comment 1? I'm not certain who to contact for it.
Looks like Les is working on it in the issue. We're on two week sprints so the earliest this would be out is halloween.
(Also, thanks for giving us a heads up and filing the issue!)
Test pilot will update this week, we can land this next week.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/6be7ac2dffd2 remove references to getExtensionUUID, r=aswan
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(mixedpuppy) → qe-verify-
You need to log in before you can comment on or make changes to this bug.