Closed
Bug 1291426
Opened 9 years ago
Closed 3 years ago
Couldn't load XPCOM Bustage fix: Package all required VS2015 CRT DLLs (Port Bug 1204202)
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: philip.chee, Assigned: philip.chee, NeedInfo)
References
Details
Attachments
(1 file)
1.62 KB,
patch
|
iannbugzilla
:
review-
frg
:
feedback-
|
Details | Diff | Splinter Review |
Startup Error: Couldn't load XPCOM Bustage
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Assignee: installer → philip.chee
Status: NEW → ASSIGNED
Attachment #8777064 -
Flags: review?(iann_bugzilla)
Attachment #8777064 -
Flags: feedback?(frgrahl)
![]() |
||
Comment 2•9 years ago
|
||
Comment on attachment 8777064 [details] [diff] [review]
Package missing msvcp140.dll and vcruntime140.dll
The build is not guaranteed to work without the standalone runtime installed if one of the two parts is missing as was the case here. It definitly won't on Vista and XP and might not in 7 to 8.1.
While reverting to the current Firefox behaviour doesn't break things I wouldn't change it. We had a report in bug 1286373 where leaving the ucrt out did cause the same problem.
Personally I would like to see a change in the mozilla base configs so that either both need to point to valid redists if one if the two options is set.
Attachment #8777064 -
Flags: feedback?(frgrahl) → feedback-
Comment 3•9 years ago
|
||
I've just checked my c-c, c-a and c-b Windows builds from https://l10n.mozilla-community.org/~akalla/unofficial/seamonkey/nightly/ on WinXP and Win7 and neither the 32 nor the 64 bit builds show the problem here: all install, and run correctly, and I see both files (msvcp140.dll and vcruntime140.dll) in the installation directories.
So on the one side, it seems like a build conf/env error for me. But on the other side, the packaging should always break with an error, if it cannot package those files - instead of producing something unusable.
Comment on attachment 8777064 [details] [diff] [review]
Package missing msvcp140.dll and vcruntime140.dll
>+++ b/suite/installer/Makefile.in
I don't think any changes should be made to this file.
>+++ b/suite/installer/package-manifest.in
> #if MOZ_PACKAGE_MSVC_DLLS
> @BINPATH@/@MSVC_C_RUNTIME_DLL@
> @BINPATH@/@MSVC_CXX_RUNTIME_DLL@
>+#endif
>+#if MOZ_PACKAGE_WIN_UCRT_DLLS
> @BINPATH@/api-ms-win-*.dll
> @BINPATH@/ucrtbase.dll
> #endif
> #endif
Rather than the above, maybe something like:
#if MOZ_PACKAGE_MSVC_DLLS
@BINPATH@/@MSVC_C_RUNTIME_DLL@
@BINPATH@/@MSVC_CXX_RUNTIME_DLL@
+#if MOZ_PACKAGE_WIN_UCRT_DLLS
@BINPATH@/api-ms-win-*.dll
@BINPATH@/ucrtbase.dll
+#endif
#endif
#endif
Attachment #8777064 -
Flags: review?(iann_bugzilla) → review-
![]() |
Assignee | |
Comment 5•8 years ago
|
||
> >+++ b/suite/installer/Makefile.in
> I don't think any changes should be made to this file.
> Rather than the above, maybe something like:
> #if MOZ_PACKAGE_MSVC_DLLS
> @BINPATH@/@MSVC_C_RUNTIME_DLL@
> @BINPATH@/@MSVC_CXX_RUNTIME_DLL@
> +#if MOZ_PACKAGE_WIN_UCRT_DLLS
> @BINPATH@/api-ms-win-*.dll
> @BINPATH@/ucrtbase.dll
> +#endif
> #endif
> #endif
I agree, however this won't work without changes to Makefile.in
Flags: needinfo?(iann_bugzilla)
What changes would be needed? Outside of the installer/Makefile.in and package-manifest.in are MOZ_PACKAGE_MSVC_DLLS / MOZ_PACKAGE_WIN_UCRT_DLLS used?
Flags: needinfo?(iann_bugzilla) → needinfo?(philip.chee)
![]() |
||
Comment 7•3 years ago
|
||
Fixed for sure.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•