Baldr: add Instance-to-WasmInstanceObject edge

RESOLVED FIXED in Firefox 51

Status

()

Core
JavaScript Engine
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: luke, Assigned: luke)

Tracking

Trunk
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
This is necessary for the debugger which starts with an Instance (found by stack-walking) and needs to get its WasmInstanceObject for a Debugger wrapper.
(Assignee)

Comment 1

a year ago
Created attachment 8777133 [details] [diff] [review]
instance-object-edge

The debugger already needed a weak-set of WasmInstanceObjects so wasm::Compartment maintained two lists: a list of Instance* and a weak set of WasmInstanceObject*.  By adding an edge Instance->WasmInstanceObject, we can now remove the weak set.
Attachment #8777133 - Flags: review?(terrence)
Comment on attachment 8777133 [details] [diff] [review]
instance-object-edge

Review of attachment 8777133 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense and seems simpler too.
Attachment #8777133 - Flags: review?(terrence) → review+

Comment 3

a year ago
Pushed by lwagner@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/da5315b797a3
Baldr: add Instance-to-WasmInstanceObject edge (r=terrence)

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/da5315b797a3
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.